From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A253FC5DF8C for ; Fri, 21 Aug 2026 09:53:02 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wxLvm-0004XV-SM; Fri, 21 Aug 2026 05:52:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wxLvj-0004Wr-HF for qemu-arm@nongnu.org; Fri, 21 Aug 2026 05:52:55 -0400 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wxLvh-00036F-2X for qemu-arm@nongnu.org; Fri, 21 Aug 2026 05:52:54 -0400 Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-499b2981a7bso8770495e9.3 for ; Fri, 21 Aug 2026 02:52:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1787305971; x=1787910771; darn=nongnu.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=AwP/yWfGPx1h2d5TCJ6y+1qxsK3YP7lopFi3pzqk8ko=; b=G64q80TSLA5pHgr9/qpQ9B44R78Xom1RenqQP/rU1ACXrozkXmd8EA5nE3+33IjZ6s Au+Q82rA7wwt9jInC74/4Ws8KWcWMS4XXAE9mkN2lPllN2oe3bPN7hCOpVlSQ4Yb5ogp 1bdLjS2YY4l+YVDmXmAsnPcCpsVOl2+FFTVuH1jv26X/3DKO6/k442P5kOUBCoTyknsE aTKjHQhRr9EDYpHVqXA4SoUEQh0pdyzWDM/ttLhImMpXP+akbkZcK20tDAVDYwr6b/pA edw4J49svW14mfdQHdyU1TAAFYopAcnFhwk1+7uuNkDCxeavCNdO3/vnP/pGwl3EJ6Ld rqAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787305971; x=1787910771; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=AwP/yWfGPx1h2d5TCJ6y+1qxsK3YP7lopFi3pzqk8ko=; b=P7VIVxlyj6DVA+UexrxFfsEVH+ttD6v6zqApyTlKssAPxd285QcZ9RKbid4mb2zIeo DO0uCHMDV6aewaW4YC0fa4r0GkBrwOpE6ohsRjY3hUIBjjpZg9wJn8BCvIZm0guM5np0 GVOj1x81Du06hxNq82Fet5Xcq9UscCSxFuOAz87Wqoyg13qEh/2Qtb9RRMZT3ZPfQy2K 6ZqyA+dyOByUypQaenG8VPrzUI87rDabzr7TVbc5YLtJFOS55gaeLtKANfPER7vXXXtX A1CAiKNtCSvCQSw0DvOMD9wS/vDXBwKqjSku91BX/7/SPzBNUQM60dZZhbncENvtiR8N i3VQ== X-Forwarded-Encrypted: i=1; AHgh+RoybPMUoGN9jfp3sgnWhhjeUPrT2dvfxKjLmSXlGMgpOZPJe/s8Ln3bHQNZi+JxxUPGP9OLVMnaeQ==@nongnu.org X-Gm-Message-State: AOJu0YzSyN1sDYE0cUHFVaOmBbtJcWs7wuqm57FUy3UNHaeLmOIyYjQZ CmKqpIbhsAQL4pycFuepZUBwebmlzLlvjnmNJqmIjfopktuH9F92zB+ZA74RESr8m5c= X-Gm-Gg: AR+sD12v9TofYJdz3yr+mPdu8cYJ/vQK3dIqkTJia9urIhfX/sgtF4S2wwNdrttW6DF 9bm7NPT1XmlISa/WbDdDm4HbYs5hn5eHZUnkWfDFRRDUfzMeVWQvifmDpcd+4lb7n5wUuy4oBXA VlIKde3qL1a/aHalR01aUYUFq79PEVR/Lb5ncK6hn5VPWGp952niDAEqlXvXKpAMzpb8Xy1t21L Y9RbNCGTNRUE2yaQEf6bWtCzWR/Hcz24euc6y6aE9RI5GtHP0L3RP/n5kkZkKgDmzCGe77Ekc3J v2ghRLm6kdTKqriINBy/WsvUxFr8HJv+0dAc8ZuWfefAKa9+MnVitnnUQVPQM/FFsZySe8Fbif8 960PIe7pnNUHyCqiOxtI80Ar+Fpo1+HbGxU353xQojogP0vFRmNmKfan3Vctih48+XW0Cbn4piG 6zLSaKT90rbu4DsvsVX7huNkIMp4CKeNxnxPeHtvT7HaML5oTOcOS4ZYBs+vV/TQ== X-Received: by 2002:a05:600c:3544:b0:493:f140:c3fb with SMTP id 5b1f17b1804b1-499b8301874mr65796535e9.7.1787305971175; Fri, 21 Aug 2026 02:52:51 -0700 (PDT) Received: from linaro.org ([2a10:d582:31e:0:fa47:b339:78a1:d4c6]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499b90e3138sm22336665e9.4.2026.08.21.02.52.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 02:52:50 -0700 (PDT) Date: Fri, 21 Aug 2026 10:52:48 +0100 From: Jim MacArthur To: Tao Tang Cc: Eric Auger , Peter Maydell , qemu-devel@nongnu.org, qemu-arm@nongnu.org, Chen Baozi , Pierrick Bouvier , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Mostafa Saleh , Chao Liu Subject: Re: [RFC v5 02/28] hw/arm/smmuv3: Introduce banked registers for SMMUv3 state Message-ID: References: <20260813161515.2788900-1-tangtao1634@phytium.com.cn> <20260813162410.2805113-2-tangtao1634@phytium.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260813162410.2805113-2-tangtao1634@phytium.com.cn> Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=jim.macarthur@linaro.org; helo=mail-wm1-x32a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org On Fri, Aug 14, 2026 at 12:24:07AM +0800, Tao Tang wrote: > Rework the SMMUv3 state management by introducing a banked register > structure. This is a purely mechanical refactoring with no functional > changes. > > To support multiple security states, a new enum, SMMUSecSID, is > introduced to identify each state, sticking to the spec terminology. > > A new structure, SMMUv3RegBank, is then defined to hold the state > for a single security context. The main SMMUv3State now contains an > array of these banks, indexed by SMMUSecSID. This avoids the need for > separate fields for non-secure and future secure registers. > > All existing code, which handles only the Non-secure state, is updated > to access its state via s->bank[SMMU_SEC_SID_NS]. A local bank helper > pointer is used where it improves readability. > > Function signatures and logic remain untouched in this commit to > isolate the structural changes and simplify review. This is the > foundational step for building multi-security-state support. > > static void smmuv3_reset(SMMUv3State *s) > { > - s->cmdq.base = deposit64(s->cmdq.base, 0, 5, SMMU_CMDQS); > - s->cmdq.prod = 0; > - s->cmdq.cons = 0; > - s->cmdq.entry_size = sizeof(struct Cmd); > - s->eventq.base = deposit64(s->eventq.base, 0, 5, SMMU_EVENTQS); > - s->eventq.prod = 0; > - s->eventq.cons = 0; > - s->eventq.entry_size = sizeof(struct Evt); > - > - s->features = 0; > - s->sid_split = 0; > - s->cr[0] = 0; > - s->cr0ack = 0; > - s->irq_ctrl = 0; > - s->gerror = 0; > - s->gerrorn = 0; > + SMMUv3RegBank *bank = smmuv3_bank(s, SMMU_SEC_SID_NS); > + > + bank->cmdq.base = deposit64(bank->cmdq.base, 0, 5, SMMU_CMDQS); > + bank->cmdq.prod = 0; > + bank->cmdq.cons = 0; > + bank->cmdq.entry_size = sizeof(struct Cmd); > + bank->eventq.base = deposit64(bank->eventq.base, 0, 5, SMMU_EVENTQS); > + bank->eventq.prod = 0; > + bank->eventq.cons = 0; > + bank->eventq.entry_size = sizeof(struct Evt); > + > + bank->features = 0; > + bank->sid_split = 0; > + bank->cr[0] = 0; > + bank->cr0ack = 0; > + bank->irq_ctrl = 0; > + bank->gerror = 0; > + bank->gerrorn = 0; > + bank->gbpa = SMMU_GBPA_RESET_VAL; > + > + s->aidr = 0x1; > s->statusr = 0; > - s->gbpa = SMMU_GBPA_RESET_VAL; > } Why reset s->aidr here? It should be read-only and set in smmuv3_init_id_regs. It won't do any harm and the reset of this patch looks correct, so: Reviewed-by: Jim MacArthur