From: Benjamin Tissoires <bentiss@kernel.org>
To: Jiri Kosina <jikos@kernel.org>
Cc: Michael Bommarito <michael.bommarito@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: hyperv: fix build breakage with certain configs
Date: Fri, 21 Aug 2026 15:00:31 +0200 [thread overview]
Message-ID: <aohLe1xiM5RmtvW7@beelink> (raw)
In-Reply-To: <p2s14pq5-s7rs-qn60-7s55-66prq154q084@xreary.bet>
On Aug 21 2026, Jiri Kosina wrote:
> From: Jiri Kosina <jkosina@suse.com>
>
> If CONFIG_HID_HYPERV is built-in (=y) while CONFIG_KUNIT is either
> disabled (=n) or built as a module (=m), the linker fails to resolve
> kunit_mem_assert_format when creating vmlinux.
I believe the commit description is wrong here. If CONFIG_KUNIT=n,
because HID_HYPERV_MOUSE_KUNIT_TEST `depends on KUNIT`, there is no issue.
That being said, this is just the commit description which is wrong, the
code looks good to me. With that fixed:
Acked-by: Benjamin Tissoires <bentiss@kernel.org>
Cheers,
Benjamin
>
> Fix the dependencies in Kconfig.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202608190536.d9qCkWWc-lkp@intel.com/
> Fixes: 83df7b5fa6735b5084ecd2 ("HID: hyperv: add KUnit coverage for device info bounds")
> Signed-off-by: Jiri Kosina <jkosina@suse.com>
> ---
> drivers/hid/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index aa7fa11a0197..a81bf51cbcf1 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -1253,7 +1253,7 @@ config HID_HYPERV_MOUSE
>
> config HID_HYPERV_MOUSE_KUNIT_TEST
> bool "KUnit tests for Hyper-V mouse driver" if !KUNIT_ALL_TESTS
> - depends on KUNIT && HID_HYPERV_MOUSE
> + depends on KUNIT && (HID_HYPERV_MOUSE = KUNIT || KUNIT = y)
> default KUNIT_ALL_TESTS
> help
> Builds unit tests for the Hyper-V synthetic HID driver.
> --
> Jiri Kosina
> SUSE Labs
>
>
next prev parent reply other threads:[~2026-08-21 13:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-21 9:29 [PATCH] HID: hyperv: fix build breakage with certain configs Jiri Kosina
2026-08-21 13:00 ` Benjamin Tissoires [this message]
2026-08-21 13:04 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aohLe1xiM5RmtvW7@beelink \
--to=bentiss@kernel.org \
--cc=jikos@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.bommarito@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.