Re: [PATCH 28/45] clk: rockchip: Make sure clk_init_data is fully initialized

[Sebastian Reichel <sebastian.reichel@collabora.com>]

[-- Attachment #1: Type: text/plain, Size: 5479 bytes --]

Hi,

On Fri, Aug 21, 2026 at 10:53:38AM +0200, Geert Uytterhoeven wrote:
> The clk_init_data structure contains several mutually-exclusive members
> for different methods to specify the possible parents of a clock,
> prompting drivers to initialize only the members they need.  However,
> not initializing all members may cause subtle issues, which are only
> exposed when CONFIG_INIT_STACK_ALL_PATTERN or CONFIG_INIT_STACK_NONE is
> enabled.
> 
> Make sure all members are fully initialized, to avoid such bugs, and to
> prevent future breakage when converting drivers to a different method
> for specifying the parents.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Compile-tested only.
> ---

Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>

Greetings,

-- Sebstian

>  drivers/clk/rockchip/clk-cpu.c       | 2 +-
>  drivers/clk/rockchip/clk-ddr.c       | 2 +-
>  drivers/clk/rockchip/clk-gate-grf.c  | 2 +-
>  drivers/clk/rockchip/clk-inverter.c  | 2 +-
>  drivers/clk/rockchip/clk-mmc-phase.c | 2 +-
>  drivers/clk/rockchip/clk-muxgrf.c    | 2 +-
>  drivers/clk/rockchip/clk-pll.c       | 2 +-
>  drivers/clk/rockchip/clk.c           | 2 +-
>  8 files changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/clk/rockchip/clk-cpu.c b/drivers/clk/rockchip/clk-cpu.c
> index 6205af9ba88a8def..eb6b8b878e4dbeea 100644
> --- a/drivers/clk/rockchip/clk-cpu.c
> +++ b/drivers/clk/rockchip/clk-cpu.c
> @@ -304,7 +304,7 @@ struct clk *rockchip_clk_register_cpuclk(const char *name,
>  			int nrates, void __iomem *reg_base, spinlock_t *lock)
>  {
>  	struct rockchip_cpuclk *cpuclk;
> -	struct clk_init_data init;
> +	struct clk_init_data init = {};
>  	struct clk *clk, *cclk;
>  	int ret;
>  
> diff --git a/drivers/clk/rockchip/clk-ddr.c b/drivers/clk/rockchip/clk-ddr.c
> index 81ae8a4ee30ed95c..fbb702d0b9d996d5 100644
> --- a/drivers/clk/rockchip/clk-ddr.c
> +++ b/drivers/clk/rockchip/clk-ddr.c
> @@ -97,7 +97,7 @@ struct clk *rockchip_clk_register_ddrclk(const char *name, int flags,
>  					 spinlock_t *lock)
>  {
>  	struct rockchip_ddrclk *ddrclk;
> -	struct clk_init_data init;
> +	struct clk_init_data init = {};
>  	struct clk *clk;
>  
>  	ddrclk = kzalloc_obj(*ddrclk);
> diff --git a/drivers/clk/rockchip/clk-gate-grf.c b/drivers/clk/rockchip/clk-gate-grf.c
> index 88e409e91a636aa1..458314a2569181d1 100644
> --- a/drivers/clk/rockchip/clk-gate-grf.c
> +++ b/drivers/clk/rockchip/clk-gate-grf.c
> @@ -73,7 +73,7 @@ struct clk *rockchip_clk_register_gate_grf(const char *name,
>  		u8 gate_flags)
>  {
>  	struct rockchip_gate_grf *gate;
> -	struct clk_init_data init;
> +	struct clk_init_data init = {};
>  	struct clk *clk;
>  
>  	if (IS_ERR(regmap)) {
> diff --git a/drivers/clk/rockchip/clk-inverter.c b/drivers/clk/rockchip/clk-inverter.c
> index bf9072ed9fd4daed..e6c7dad60e966288 100644
> --- a/drivers/clk/rockchip/clk-inverter.c
> +++ b/drivers/clk/rockchip/clk-inverter.c
> @@ -75,8 +75,8 @@ struct clk *rockchip_clk_register_inverter(const char *name,
>  				void __iomem *reg, int shift, int flags,
>  				spinlock_t *lock)
>  {
> -	struct clk_init_data init;
>  	struct rockchip_inv_clock *inv_clock;
> +	struct clk_init_data init = {};
>  	struct clk *clk;
>  
>  	inv_clock = kmalloc_obj(*inv_clock);
> diff --git a/drivers/clk/rockchip/clk-mmc-phase.c b/drivers/clk/rockchip/clk-mmc-phase.c
> index 4efd22953f3e0533..d92bea75faf73767 100644
> --- a/drivers/clk/rockchip/clk-mmc-phase.c
> +++ b/drivers/clk/rockchip/clk-mmc-phase.c
> @@ -205,8 +205,8 @@ struct clk *rockchip_clk_register_mmc(const char *name,
>  				struct regmap *grf, int grf_reg,
>  				int shift)
>  {
> -	struct clk_init_data init;
>  	struct rockchip_mmc_clock *mmc_clock;
> +	struct clk_init_data init = {};
>  	struct clk *clk;
>  	int ret;
>  
> diff --git a/drivers/clk/rockchip/clk-muxgrf.c b/drivers/clk/rockchip/clk-muxgrf.c
> index ccbb1379501ab474..ecdc77654813a3c3 100644
> --- a/drivers/clk/rockchip/clk-muxgrf.c
> +++ b/drivers/clk/rockchip/clk-muxgrf.c
> @@ -59,7 +59,7 @@ struct clk *rockchip_clk_register_muxgrf(const char *name,
>  				int shift, int width, int mux_flags)
>  {
>  	struct rockchip_muxgrf_clock *muxgrf_clock;
> -	struct clk_init_data init;
> +	struct clk_init_data init = {};
>  	struct clk *clk;
>  
>  	if (IS_ERR(regmap)) {
> diff --git a/drivers/clk/rockchip/clk-pll.c b/drivers/clk/rockchip/clk-pll.c
> index 706ca4b344d399a3..7204b09243d483ae 100644
> --- a/drivers/clk/rockchip/clk-pll.c
> +++ b/drivers/clk/rockchip/clk-pll.c
> @@ -1069,7 +1069,7 @@ struct clk *rockchip_clk_register_pll(struct rockchip_clk_provider *ctx,
>  		unsigned long flags, u8 clk_pll_flags)
>  {
>  	const char *pll_parents[3];
> -	struct clk_init_data init;
> +	struct clk_init_data init = {};
>  	struct rockchip_clk_pll *pll;
>  	struct clk_mux *pll_mux;
>  	struct clk *pll_clk, *mux_clk;
> diff --git a/drivers/clk/rockchip/clk.c b/drivers/clk/rockchip/clk.c
> index ee8c79b938d3c15b..10df21178ba483e2 100644
> --- a/drivers/clk/rockchip/clk.c
> +++ b/drivers/clk/rockchip/clk.c
> @@ -257,7 +257,7 @@ static struct clk *rockchip_clk_register_frac_branch(
>  
>  	if (child) {
>  		struct clk_mux *frac_mux = &frac->mux;
> -		struct clk_init_data init;
> +		struct clk_init_data init = {};
>  		struct clk *mux_clk;
>  		int ret;
>  
> -- 
> 2.43.0
> 
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]