From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1003F494836 for ; Fri, 21 Aug 2026 14:15:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787321710; cv=none; b=dxKxqH8RJ6+mVEWrfCNtGELUJhU5/HCLw7G5VxjxdLfedeKbwQGInFBd/2nnrKtbrW1YD45d7628zAMuT9U+qXVn7XKjikU6/qnsote+8QuDASfAiMRv5PNDwi/32UXNVWCGyAM9L2YKmv0lAg9WHofXN50MBxjk8fSDGAR5msY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787321710; c=relaxed/simple; bh=JW5czaD2mxQt2d7DRTx1WpKHhDSc7gUWTlFvWBzinq8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=me1ADxsgBUGVRGAPGULU2V7l9gaAC637keZQBBcVBFBUmn8HQzlkA1kPpgLQIQG2uuQ5Wv+dulQJJ2zvKWk73ZG/tpuCdHMA5pQTeG/QxxiBm5MDuvQE7SeTOS+6XfCDC9LHK2DMU9htBg1H4eVI0yhXPdDg0rXQhVwjC8zfiBo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=sP5BNLGw; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sP5BNLGw" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4956869750eso6733105e9.2 for ; Fri, 21 Aug 2026 07:15:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787321707; x=1787926507; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=UfCLiVXz7TZXppNIA+DfwYYVjdDOLWdByz+tfwQpvlI=; b=sP5BNLGw70zZ5++Y8kXq2wYYSpNBe4L26labrpgTmhwe8C9XWF8oVzDS/FkFk6qwj7 sTpoH2Naa9Dh9MeB92W92Kp/wh+iTCFqSc41f0gIPlCNEWb+HOc5GsmQMwxfd5FoKrxy p782Nz5qUec4VRgXmUYmBfDnRDD37pZO8YrQrH+sXJ2qbQH1xE1J0a4SFnzSU3YGVQZD zNvIj9oyh+NL2seLxInqA0PrW5c9yidlkzRyjhR2kBBOIAwxtiIXPzNLRQQDadZQsf2K iKRjnEvKVVsljjzecpwaENRRMen+gE9ypsX+dcnH5XDzPBkEQcsKZUp6AGFDiKkxU3+F W3TA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787321707; x=1787926507; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=UfCLiVXz7TZXppNIA+DfwYYVjdDOLWdByz+tfwQpvlI=; b=aP+l248/xt9uCHQ4Eyzd080RWLOIQO18GOcrvfwJZ2tPlFLOS3+znkaN+br99YOftH 2clPhMJU8W7KMbk1V7tZQHZbyHZ28Ls3IVMg7skgyQ4oD/MJMgiFM0qtaFA7b9rpI0o6 AawBXoAPNZbCoLXkN4K1fseWnr9BDwS//7MQfMwa5rByaHMS7BNe8oI0HnO4zjst3oFI 2uoExTtZx8JD5KkJoVFx/KMD/IyujkFM2WiZhEWMou+pLDB/+mrUFRICtBhNq1H56gla 9IhSTBLcEEDenNOADVPh2/qfyzuZhxYVciV35iX+oDaT2R37rN0RHeKidCq5m5p1ygK7 6eNQ== X-Forwarded-Encrypted: i=1; AHgh+RoCDRa/I0wEUENO4Uy16/hH3Ot6mQAmiq62roz55UIbgYbc/avInuIO1eXa/q28Yd+20muaTEbkrXoh5bE=@vger.kernel.org X-Gm-Message-State: AOJu0YxIrQKMegYbWK5EAuMxexeWJc/IzkqeBsmQHVkZLZRnlmRGJt+9 MO5kYuqcXzUcW8AUzGxQrsZy8/WSh0vm9Ffy6sSTlY3+WYe/tXW0IayT X-Gm-Gg: AR+sD11twEdVsI8Vq6knwbV+QR/wNt798uLTU57M3NyXlFKzyb7I+9iqEoo7wQK8JbK NDiqlsnvyOBtwGQvX0ZKJA7GkBAlk/DWOQ2Lj/Hnn6CeubgdvY0xFgwFiIQjIymN1CJS1BQrIkQ Cl5sjORElsjFuqgpBK/P9RwYyZ0K29PG52ec1NuKKI19OXU8lB5snofiIHvcAmCODhT3jZDx6rN XIWRFbydwc9O69pCOkaVvw1zFQJ+0yQ+2PVjf/duAGKw9U3FEgITkh8hurZ5iwrmMDgrFw+v0rL e6LaZuSLnpcwj0A0K00NmGe2FDryy/C3G5AuEg2rQpVxnITPAwaDhDICNoE+WnJke+9MY8gJmat EetKIDs4KC+B6TlACCpDG2FUneXLepcApzNz+l/fB+iEK0Y+RovNXVBGc1OnYle+ffMVfBpgf+C /uQ6yx+TGHNPE2L6vX6NyiuTqSJQTrAS2Vf6ebDboS0rdNe1oI9ZvHu2byenSzZEylUgo= X-Received: by 2002:a05:600c:1390:b0:490:e5c1:b8bf with SMTP id 5b1f17b1804b1-499b83019eemr95249565e9.13.1787321706912; Fri, 21 Aug 2026 07:15:06 -0700 (PDT) Received: from localhost ([2c0f:3d00:6be:8900:ce5e:9212:ea4b:f30]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499bf9efa89sm1855765e9.4.2026.08.21.07.15.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 07:15:06 -0700 (PDT) Date: Fri, 21 Aug 2026 17:15:02 +0300 From: Dan Carpenter To: Tiago Panizio Gottardo Cc: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: octeon: fix function declaration formatting Message-ID: References: <20260821041255.1616843-1-tiago.panizio@hotmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Aug 21, 2026 at 11:04:09AM -0300, Tiago Panizio Gottardo wrote: > Move the cvm_oct_of_get_child() return type to a separate line and keep > the function name with its arguments. > > No functional changes intended. > > Signed-off-by: Tiago Panizio Gottardo > --- > Changes in v2: > - Split out one focused formatting cleanup. > - Dropped RGMII formatting and parentheses changes. > - Dropped unrelated alignment cleanups. > > drivers/staging/octeon/ethernet.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c > index 42ec4b8324a8..e668e3baaa31 100644 > --- a/drivers/staging/octeon/ethernet.c > +++ b/drivers/staging/octeon/ethernet.c > @@ -621,8 +621,8 @@ static const struct net_device_ops cvm_oct_pow_netdev_ops = { > #endif > }; > > -static struct device_node *cvm_oct_of_get_child > - (const struct device_node *parent, int reg_val) > +static struct device_node * > +cvm_oct_of_get_child(const struct device_node *parent, int reg_val) So, in the end, checkpatch is just a perl script. It's not a king. If it isn't useful, then just ignore it... None of the other functions are declared this way. The thinking in the original code was that they wanted to do: static struct device_node *cvm_oct_of_get_child(const struct device_node *parent, int reg_val) But that's 82 characters and checkpatch used to complain if you went over 80 characters. Probably the right thing here is to do the original thing because checkpatch doesn't complain until 100 characters now. Really, the original code is kind of fine as-is... regards, dan carpenter