From: Dan Carpenter <error27@gmail.com>
To: Omer El Idrissi <omer.e.idrissi@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: modify misleading comment
Date: Fri, 21 Aug 2026 23:53:50 +0300 [thread overview]
Message-ID: <aoi63mXmusBP-Wy3@stanley.mountain> (raw)
In-Reply-To: <20260821195823.87471-1-omer.e.idrissi@gmail.com>
On Fri, Aug 21, 2026 at 09:58:23PM +0200, Omer El Idrissi wrote:
> The comment suggests that rtw_unregister_cmd_alive is called
> by the ISR, while it's called by function rtw_cmd_thread which runs in
> the kernel thread context.
>
> Signed-off-by: Omer El Idrissi <omer.e.idrissi@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
> index b9f8cf1014ed..a4831dc145eb 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
> @@ -891,7 +891,7 @@ void rtw_unregister_tx_alive(struct adapter *padapter)
> }
>
> /*
> - * Caller: ISR
> + * Caller: not ISR
The original comment is obviously wrong, and that's bad. But is "not ISR"
useful? Probably we might as well just delete the comment. It's not
like people don't have ctags.
regards,
dan carpenter
prev parent reply other threads:[~2026-08-21 20:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-21 19:58 [PATCH] staging: rtl8723bs: modify misleading comment Omer El Idrissi
2026-08-21 20:53 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aoi63mXmusBP-Wy3@stanley.mountain \
--to=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=omer.e.idrissi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.