From: Mike Rapoport <rppt@kernel.org>
To: Meijing Zhao <zhaomeijing100@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Wandun Chen <chenwandun@lixiang.com>,
Meijing Zhao <zhaomeijing@lixiang.com>
Subject: Re: [PATCH v2 RESEND 0/3] mm: memblock: fix debugfs flag reporting and synchronization
Date: Sun, 23 Aug 2026 17:43:11 +0300 [thread overview]
Message-ID: <aosG_685XrPdrAJD@kernel.org> (raw)
In-Reply-To: <20260821020910.3428585-1-zhaomeijing100@gmail.com>
Hi,
On Fri, Aug 21, 2026 at 10:09:07AM +0800, Meijing Zhao wrote:
> From: Meijing Zhao <zhaomeijing@lixiang.com>
>
> The memblock debugfs interface has two issues when reporting region
> flags. MEMBLOCK_RSRV_HUGETLB has no corresponding name, and regions
> with multiple flags only show the lowest set bit.
>
> In addition, memblock_debug_show() walks the region arrays without
> synchronizing against memory hotplug. If memory hotplug grows an array,
> the debugfs reader may continue accessing the old array after it has
> been freed.
>
> Add the missing HugeTLB flag name, report every set bit including those
> beyond flagname[], and hold the memory hotplug read lock while walking
> the arrays.
>
> With the series applied, a HugeTLB bootmem reservation is reported as:
>
> RSV_KERN|RSV_HUGETLB
>
> RESEND:
> - Regenerate the series from the same clean base as v1. The previous v2
> was inadvertently generated with an unrelated MEMBLOCK_NODUMP change
> in the patch context, causing apply failures. No code changes.
I presume the changes were on top of linux-next and it's not clear how to
apply them before the end of the merge window.
Can you please resend the patches after v7.3-rc1 is out and base them on
that?
> Changes in v2:
> - Report set bits beyond flagname[] as UNKNOWN instead of ignoring them.
> - Add a separate patch to synchronize debugfs reads with memory hotplug.
>
> v1: https://lore.kernel.org/linux-mm/20260819075422.2387980-1-zhaomeijing100@gmail.com/
>
> Meijing Zhao (3):
> mm: memblock: add missing HugeTLB flag name
> mm: memblock: show all region flags in debugfs
> mm: memblock: synchronize debugfs reads with memory hotplug
>
> mm/memblock.c | 26 ++++++++++++++++++--------
> 1 file changed, 18 insertions(+), 8 deletions(-)
>
> --
> 2.25.1
--
Sincerely yours,
Mike.
prev parent reply other threads:[~2026-08-23 14:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-21 2:09 [PATCH v2 RESEND 0/3] mm: memblock: fix debugfs flag reporting and synchronization Meijing Zhao
2026-08-21 2:09 ` [PATCH v2 RESEND 1/3] mm: memblock: add missing HugeTLB flag name Meijing Zhao
2026-08-21 2:09 ` [PATCH v2 RESEND 2/3] mm: memblock: show all region flags in debugfs Meijing Zhao
2026-08-24 15:15 ` Mike Rapoport
2026-08-25 1:56 ` Meijing Zhao
2026-08-21 2:09 ` [PATCH v2 RESEND 3/3] mm: memblock: synchronize debugfs reads with memory hotplug Meijing Zhao
2026-08-25 9:35 ` Mike Rapoport
2026-08-23 14:43 ` Mike Rapoport [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aosG_685XrPdrAJD@kernel.org \
--to=rppt@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=chenwandun@lixiang.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=zhaomeijing100@gmail.com \
--cc=zhaomeijing@lixiang.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.