From: Steffen Klassert <steffen.klassert@secunet.com>
To: Lilly Aronleigh <lilly@aronleigh.au>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Christian Hopps <chopps@labn.net>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net] xfrm: iptfs: avoid canceling reorder-window drop timer
Date: Mon, 24 Aug 2026 07:14:37 +0200 [thread overview]
Message-ID: <aovTPU8CUB_Ud4zT@secunet.com> (raw)
In-Reply-To: <CAFrrV-O1fesaza+5_WqH8OciXRu9KKE4UsB6RcMamDu0j2-nBA@mail.gmail.com>
On Thu, Jul 30, 2026 at 01:12:44PM +1000, Lilly Aronleigh wrote:
> IP-TFS uses xtfs->drop_timer for both partial inner-packet
> reassembly and the reorder-window drop timeout. Reassembly completion
> currently cancels the timer unconditionally.
>
> That is only correct when the reorder window is empty. If the reorder
> window already contains saved packets, the same timer belongs to the
> reorder-window state and must remain armed so the missing sequence can
> be considered lost and the window can advance.
>
> Only cancel drop_timer from __iptfs_reassem_done() when the reorder
> window has no saved packets. The existing drop_lock serializes this
> with the reorder-window paths, and a failed cancel remains harmless.
>
> Tested with a reproducer that completes reassembly while the reorder
> window contains saved packets.
>
> With this change, the reorder-window timeout remains active and the
> window can advance correctly when the missing sequence is not received.
>
> Fixes: 0756947654468 ("xfrm: iptfs: handle received fragmented inner packets")
> Assisted-by: ChatGPT:5.5-extrahigh
> Assisted-by: Claude:4.6-opus
> Signed-off-by: Lilly Aronleigh <lilly@aronleigh.au>
Your patch does not apply to the ipsec tree.
Please rebase onto the ipsec tree, thanks!
prev parent reply other threads:[~2026-08-24 5:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-30 3:12 [PATCH net] xfrm: iptfs: avoid canceling reorder-window drop timer Lilly Aronleigh
2026-08-24 5:14 ` Steffen Klassert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aovTPU8CUB_Ud4zT@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=chopps@labn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=lilly@aronleigh.au \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.