From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Rob Barnes <robbarnes@google.com>
Cc: bleung@chromium.org, tomhughes@chromium.org,
chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] platform/chrome: cros_ec_proto: Fix deferred response
Date: Mon, 24 Aug 2026 05:47:27 +0000 [thread overview]
Message-ID: <aova74HsrEFQ2ZnS@google.com> (raw)
In-Reply-To: <CA+Dqm33C4x5jkDGzxwy-Poz-u135AJEh9PKCgBRvFMSz=M2AJg@mail.gmail.com>
On Wed, Aug 19, 2026 at 02:18:07PM -0700, Rob Barnes wrote:
> v3:
> - Rebase against upstream chrome-platform/for-firmware-next tree (Tzung-Bi).
It needs to rebase to "for-next" actually. But anyway, that wasn't the
original comment... It's fine as long as the patch generated against to
the correct base.
> - Fix MIME/email transport line-wrapping and formatting issues (Tzung-Bi).
It seems the issue is still there.
> diff --git a/drivers/platform/chrome/cros_ec_proto.c
> b/drivers/platform/chrome/cros_ec_proto.c
> index 1d8d9168ec1a..6d7c57e381e5 100644
> --- a/drivers/platform/chrome/cros_ec_proto.c
> +++ b/drivers/platform/chrome/cros_ec_proto.c
> @@ -138,7 +138,8 @@ static int cros_ec_xfer_command(struct
> cros_ec_device *ec_dev, struct cros_ec_co
The hunk header shouldn't wrap.
./scripts/checkpatch.pl --strict:
#48: FILE: drivers/platform/chrome/cros_ec_proto.c:137:
cros_ec_device *ec_dev, struct cros_ec_co
total: 1 errors, 0 warnings, 0 checks, 251 lines checked
prev parent reply other threads:[~2026-08-24 5:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-19 21:18 [PATCH v3] platform/chrome: cros_ec_proto: Fix deferred response Rob Barnes
2026-08-24 5:47 ` Tzung-Bi Shih [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aova74HsrEFQ2ZnS@google.com \
--to=tzungbi@kernel.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=robbarnes@google.com \
--cc=tomhughes@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.