From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C86403932ED for ; Mon, 24 Aug 2026 08:42:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787560947; cv=none; b=Np4nAn4aJeG1YTLeyZDcfDK9aJZgpa3PVYtpAQQL8GmCXoIwN2UluSbZex1Gmjo8f3+rf859UeNffQGHJuxMCccl19XIGbfDcwdOt9l/W/C43W1+y+0yU54x7bZvWDpXOpq8JHVGhTuEoviqI0q/UPU0p09HB+wc3To3P56LXUs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787560947; c=relaxed/simple; bh=PFP1ipuaeC4bQLz7Z6TaxO+mW+ATiRijRhI+QRFHzmQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Fk4qXoqOtD0z0wJuztppL+X5Kf4cfWsO9jj/GzkpdBUqgeR+wUDSxCdhVSnIrkGMW48QRP9eeIxFSeP32uA2F00k3MeBCaZtvojKLQJg19zZZh0g0kMbREUxfn/sOI/RdyUrI2ETVRb5Oj0A+ijtWLxi4cKG+ozh3rJKpwyMiO0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=SDNyjBCG; arc=none smtp.client-ip=209.85.218.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="SDNyjBCG" Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-c197eaaab00so529091266b.0 for ; Mon, 24 Aug 2026 01:42:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1787560944; x=1788165744; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=GGTqSFIdIFnX5ZwL1pucBsR+p2FUQcaSYFkmH0uw2Ps=; b=SDNyjBCG95i/jq8MZA43jz8/dimYSS9w75x40dqzei2FHGetIJ7ZoqoLmu2myllcx+ hXOekgzVeNkAcvG+88vxHkXWcsT3GnPwcyfoUk4rM5IvsRPBf3YMWpei6nRu6m6AyXsS Ozo01xn0caipy0jeKh84BLlUOqyKY8mWKwJx0ze/H84REiqgtf2ObXRtOAShTrWFaYFj eaU4Gg3cyk8fbI9osg8A4MP9gX1Do8MLSf9DDa79ZLGfUTBwTuY6Y0r7Vf5S6nREFo/D /cSzDGXxWCNMEiFgUEtutWDUko3cRyMsk/8zywN2FpKhGWJzwOATJOBLay0c17/m1GxP 3bLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787560944; x=1788165744; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=GGTqSFIdIFnX5ZwL1pucBsR+p2FUQcaSYFkmH0uw2Ps=; b=gQ8ooixDSqvydOTCHVUaWdDOQ+PjVFojo81k5xMDTEhWEE9HCJu6fbc67Z8XgxPZ1a fvbJciT+10OKT1/hZloDzbrRNTUdtdGTEP7b1fd81MyUQcTJNszJt8zuJlSmpv4XwU3E BLKCStWwUK7lkznLTpyc5REmyghR+feYkxBBiWwc2hNu5dQadS0n/b9wrFj1MvVj+Xhy gv4qT1g1tXxZM0a0hBuDFXcaUbXpy4NeTdzu6/u65CyQUuARC2AqObMiF9HEakKU7m4p je1Ke+etiWQQkCmfhGjAbbw5u4lNh3jKcIUNAMaTIsUPGEsYtkqaimzG0zBPKw/IRODv qJbA== X-Forwarded-Encrypted: i=1; AHgh+RpET/N7qKSnDhOf20DK/j8o0B6p13dAKg5RDTjI0ihqMAnZYPsqJnAZXD/KM73DCl1xZbZ7/hDpXqfpAFk=@vger.kernel.org X-Gm-Message-State: AFuF++lVdGyP0mTomzXBypQmdAxAuahheFybhOKduArl/fIO6PssRsDf zrO1Fd7FCC555i7EJhNhjkTkJdGwqDQcjyJQasGx0fJiXpD6lRU6xMHyYI4x5i4MuYg= X-Gm-Gg: AR+sD13jdv8ipIPOyy+zHEdA0wLQMq8stCHOFoOgZwDmmyLcLdKrNMs/dYk0hqXDiue zu9p8VoEhAsDYzlZfAxSG8ZOoqUlukLdW0GGSpDWneEVn29gwPtZ0XcBqfuvOag9/UrO0xibojX 4Qmee7Kr0TMmUrXHJaFMw/3Adm+NTeVRyTo7+z72VRBoW+3E/5urfWhbGD7LEmHajNMFzXw7J6Z Wgw02RsyO1TeujlE78ShdXzTUwTjNlCZJXC1MSJ9/pPZNBHwj8uOu56ZkUwl26bL/KLdk835qd/ 841K6Z5STFeeRLAj6l0i2/1xto1D3gVRME8wNzoxr7fWgV7gGeKnDY1Q6+Z3Tlj0RNVtzPVb+Ch irnzlPT/S4srJz2ag8gyk2ACOiFIKl+Vx3cF7NTlfW1im5Pg+MfqLxAdqT8B9DNfloYTjkMH22Z wuge4ZXkURIXdQkUwi1UXPNuoxlrwID0MUzorgph+OvXgAMlbNTEW3bEnSSaofJSXhocz1QON0a A== X-Received: by 2002:a17:906:2481:b0:c1c:2007:298e with SMTP id a640c23a62f3a-c246b4c5e33mr2142741366b.24.1787560944031; Mon, 24 Aug 2026 01:42:24 -0700 (PDT) Received: from localhost (109-81-81-112.rct.o2.cz. [109.81.81.112]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c24968abf18sm1238314066b.61.2026.08.24.01.42.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Aug 2026 01:42:23 -0700 (PDT) Date: Mon, 24 Aug 2026 10:42:22 +0200 From: Michal Hocko To: Ridong Chen Cc: Andrew Morton , Johannes Weiner , David Hildenbrand , Qi Zheng , Shakeel Butt , Lorenzo Stoakes , Kairui Song , Barry Song , Axel Rasmussen , Yuanchu Xie , Wei Xu , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Ridong Chen Subject: Re: [RFC PATCH 0/4] mm/vmscan: honour node reclaim limits per type Message-ID: References: <20260821081741.1340277-1-ridong.chen@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon 24-08-26 11:24:46, Ridong Chen wrote: > > > On 8/21/2026 7:20 PM, Michal Hocko wrote: > > On Fri 21-08-26 19:10:45, Ridong Chen wrote: > > > > > Did you mean that min_slab_pages and min_unmapped_pages should influence > > > > > proactive per-node reclaim? > > > > > > I apologize for being incoherent in my last email, it was after a full day > of work. What I wanted to say is that min_slab_pages and min_unmapped_pages > should *not* influence proactive per-node reclaim. > > > > > Nope, exactly opposite > > > > > > > > > > I would really appreciate it if you could clarify this further. Sorry, I'm > > > not sure I fully understand what you meant. > > > > pro-active (userspace triggered) node reclaim should completely ignore > > all those historical node_reclaim tunables. > > Yeah, this matches my understanding. Apologies again for the confusing reply. > > Since Johannes has acked patch 3, perhaps we can simply remove the > conditional check in __node_reclaim and keep the shrink loop as follows: > > ``` > @@ -7906,16 +7906,16 @@ static unsigned long __node_reclaim(struct > pglist_data *pgdat, > noreclaim_flag = memalloc_noreclaim_save(); > set_task_reclaim_state(p, &sc->reclaim_state); > > - if (node_pagecache_reclaimable(pgdat) > pgdat->min_unmapped_pages || > - node_page_state_pages(pgdat, NR_SLAB_RECLAIMABLE_B) > pgdat->min_slab_pages) { > - /* > - * Free memory by calling shrink node with increasing > - * priorities until we have enough memory freed. > - */ > - do { > - shrink_node(pgdat, sc); > - } while (sc->nr_reclaimed < nr_pages && --sc->priority >= 0); > - } > + /* > + * Free memory by calling shrink node with increasing > + * priorities until we have enough memory freed. > + * > + * What to reclaim is gated per type by sc->skip_slab_reclaim and > + * sc->skip_file_reclaim. > + */ > + do { > + shrink_node(pgdat, sc); > + } while (sc->nr_reclaimed < nr_pages && --sc->priority >= 0); > > set_task_reclaim_state(p, NULL); > memalloc_noreclaim_restore(noreclaim_flag); Could you post a stand alone patch with the full description please? -- Michal Hocko SUSE Labs