All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michal Koutný" <mkoutny@suse.com>
To: chenglingfei@foxmail.com
Cc: Tejun Heo <tj@kernel.org>, Johannes Weiner <hannes@cmpxchg.org>,
	 Jonathan Corbet <corbet@lwn.net>,
	Shuah Khan <skhan@linuxfoundation.org>,
	 Randy Dunlap <rdunlap@infradead.org>,
	cgroups@vger.kernel.org, linux-doc@vger.kernel.org,
	 linux-kernel@vger.kernel.org
Subject: Re: [PATCH] docs: cgroup-v2: fix misc.events key format description
Date: Mon, 24 Aug 2026 13:15:01 +0200	[thread overview]
Message-ID: <aowmLvkC3xed2QQI@localhost.localdomain> (raw)
In-Reply-To: <20260824-master-v1-1-6866b77e1f62@foxmail.com>

[-- Attachment #1: Type: text/plain, Size: 1603 bytes --]

Hi Lingfei.

On Mon, Aug 24, 2026 at 06:55:04PM +0800, Cheng Lingfei via B4 Relay <devnull+chenglingfei.foxmail.com@kernel.org> wrote:
>    misc.events
> -	A read-only flat-keyed file which exists on non-root cgroups. The
> -	following entries are defined. Unless specified otherwise, a value
> -	change in this file generates a file modified event. All fields in
> -	this file are hierarchical.
> +        A read-only flat-keyed file which exists on non-root cgroups. It
> +        shows, per resource, the number of times the resource usage of the
> +        cgroup and its children was about to go over the max boundary.
> +        Unless specified otherwise, a value change in this file generates a
> +        file modified event. All fields in this file are hierarchical::
>  
> -	  max
> -		The number of times the cgroup's resource usage was
> -		about to go over the max boundary.
> +          $ cat misc.events
> +          res_a.max 0
> +          res_b.max 0
> +
> +        Each entry is keyed by the resource name suffixed with ``.max``.

I reckon the docs won't list the key names verbatim. The proposed change
somewhat hides the potentiality of multiple types of events.
To correct the printed key name, I think a smaller change would make do.

@@ -2991,7 +2991,7 @@ resources (res_a and res_b) are registered then:
 	change in this file generates a file modified event. All fields in
 	this file are hierarchical.
 
-	  max
+	  <res>.max
 		The number of times the cgroup's resource usage was
 		about to go over the max boundary.
 

Thanks,
Michal

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 265 bytes --]

      reply	other threads:[~2026-08-24 11:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-24 10:55 [PATCH] docs: cgroup-v2: fix misc.events key format description Cheng Lingfei
2026-08-24 10:55 ` Cheng Lingfei via B4 Relay
2026-08-24 11:15 ` Michal Koutný [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aowmLvkC3xed2QQI@localhost.localdomain \
    --to=mkoutny@suse.com \
    --cc=cgroups@vger.kernel.org \
    --cc=chenglingfei@foxmail.com \
    --cc=corbet@lwn.net \
    --cc=hannes@cmpxchg.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=skhan@linuxfoundation.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.