All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Fernando Fernandez Mancera <fmancera@suse.de>
Cc: netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
	fw@strlen.de, phil@nwl.cc, Wei Fang <void0red@gmail.com>
Subject: Re: [PATCH nf v2] netfilter: nf_tables: fix device name and prefix match in hook lookup
Date: Mon, 24 Aug 2026 14:59:23 +0200	[thread overview]
Message-ID: <aoxAK6NwkbdUSXeR@chamomile> (raw)
In-Reply-To: <c409c65e-77b6-4bfa-bf42-027328b101dc@suse.de>

On Mon, Aug 24, 2026 at 02:23:49PM +0200, Fernando Fernandez Mancera wrote:
> On 8/24/26 2:21 PM, Pablo Neira Ayuso wrote:
> > Hi Fernando,
> > 
> > On Mon, Aug 24, 2026 at 11:28:05AM +0200, Fernando Fernandez Mancera wrote:
> > > Currently, a netdev chain or flowtable hooked to a device prefix can be
> > > unintentionally deleted by a control-plane request targeting an exact
> > > device name or even a shorter one due to the usage of min() to calculate
> > > the length to match.
> > > 
> > > Fix this by making sure an exact device match never matches a prefix and
> > > that both the target and the candidate have the same length during
> > > delete operation. The add and update paths retain the existing overlap
> > > matching to prevent a single device from matching multiple hooks.
> > 
> > netdev maintainers prefer follow ups for LLM reported issues.
> > 
> > Please, provide an incremental patch for your v1 that we can take in
> > the next PR round.
> > 
> 
> Oh really? Even in this situation?

Yes, this helps reduce pressure on the mailing list.

> Will do once the PR is accepted. The patch won't be much different
> of course.

I guess so, it will be just a simple rebase.

Thanks

  reply	other threads:[~2026-08-24 12:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-24  9:28 [PATCH nf v2] netfilter: nf_tables: fix device name and prefix match in hook lookup Fernando Fernandez Mancera
2026-08-24 12:21 ` Pablo Neira Ayuso
2026-08-24 12:23   ` Fernando Fernandez Mancera
2026-08-24 12:59     ` Pablo Neira Ayuso [this message]
2026-08-26 10:46 ` Phil Sutter
2026-08-26 10:55   ` Fernando Fernandez Mancera
2026-08-26 12:07     ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aoxAK6NwkbdUSXeR@chamomile \
    --to=pablo@netfilter.org \
    --cc=coreteam@netfilter.org \
    --cc=fmancera@suse.de \
    --cc=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=phil@nwl.cc \
    --cc=void0red@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.