From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DBFDEC5DF81 for ; Mon, 24 Aug 2026 13:01:34 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wyUIu-0001fR-FG; Mon, 24 Aug 2026 09:01:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wyUIr-0001f2-VW for qemu-devel@nongnu.org; Mon, 24 Aug 2026 09:01:29 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wyUIq-0007AF-2r for qemu-devel@nongnu.org; Mon, 24 Aug 2026 09:01:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787576487; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1kqNBWwMkUiB4RepcPTriDXGhpwogFHFImior1bqeps=; b=akZbRIgtKMCdSsn8fAX0xOQ3XAVhT+0eJYIbPG1F6GYLVIGzbqNk9bFmG5YbYgAi0lnk2Z iZ2vmar1GBbEoabsA6YoAn1wI+SnzYvf1wavp47budGgjPSGRDbUzAvIkN9vor4FE8bzvn W8EYoiqigqdUOEkd4H06tX8XjH/Iav0= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-577-7_YVMOJqMTuOjUa4NdIAtQ-1; Mon, 24 Aug 2026 09:01:22 -0400 X-MC-Unique: 7_YVMOJqMTuOjUa4NdIAtQ-1 X-Mimecast-MFC-AGG-ID: 7_YVMOJqMTuOjUa4NdIAtQ_1787576481 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3B2071831371; Mon, 24 Aug 2026 13:01:21 +0000 (UTC) Received: from redhat.com (headnet05.pony-001.prod.iad2.dc.redhat.com [10.2.32.117]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 29BB77D5; Mon, 24 Aug 2026 13:01:16 +0000 (UTC) Date: Mon, 24 Aug 2026 14:01:14 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Mark Cave-Ayland Cc: mst@redhat.com, imammedo@redhat.com, anisinha@redhat.com, philmd@mailo.com, aurelien@aurel32.net, peter.maydell@linaro.org, richard.henderson@linaro.org, marcandre.lureau@redhat.com, qemu-devel@nongnu.org, qemu-arm@nongnu.org Subject: Re: [PATCH v4 13/16] hw/acpi/pcihp.c: convert ACPI_PCIHP_IO_BASE_PROP and ACPI_PCIHP_IO_BASE_PROP to class props Message-ID: References: <20260821111550.276011-1-mark.caveayland@nutanix.com> <20260821111550.276011-14-mark.caveayland@nutanix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260821111550.276011-14-mark.caveayland@nutanix.com> User-Agent: Mutt/2.4.0 (2026-06-19) X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Fri, Aug 21, 2026 at 12:14:25PM +0100, Mark Cave-Ayland wrote: > Since the objects referenced by acpi_pcihp_init() do not inherit from a common > class, add ACPI_PCIHP_IO_BASE_PROP and ACPI_PCIHP_IO_BASE_PROP class properties > to each referenced object and remove the object properties manually added in > acpi_pcihp_init(). > > Signed-off-by: Mark Cave-Ayland > Reviewed-by: Marc-André Lureau > --- > hw/acpi/generic_event_device.c | 10 ++++++++++ > hw/acpi/ich9.c | 10 ++++++++++ > hw/acpi/pcihp.c | 5 ----- > hw/acpi/piix4.c | 9 +++++++++ > 4 files changed, 29 insertions(+), 5 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|