All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: Lucas Kornicki <lucas.kornicki@nutanix.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH 4/4] ui/vnc: notify client of clipboard peer status
Date: Mon, 24 Aug 2026 14:09:49 +0100	[thread overview]
Message-ID: <aoxCnWc9SOwYOhEK@redhat.com> (raw)
In-Reply-To: <CAJ+F1CL_Z2C_k5_40VT9P6t80Z56YBObQ1fiQpW3t_nO0h1JWg@mail.gmail.com>

On Mon, Aug 24, 2026 at 04:36:12PM +0400, Marc-André Lureau wrote:
> Hi
> 
> On Tue, Aug 18, 2026 at 5:56 PM Lucas Kornicki
> <lucas.kornicki@nutanix.com> wrote:
> >
> > Hi Marc-Andre
> >
> > I quickly became aware of the shortcomings of my v1 series and I've
> > already drafted a v2 where the cover is a bit more detailed and the
> > commits were fixed to remove the Change-IDs.
> >
> > On 8/18/26 15:33, Marc-André Lureau wrote:
> > > !-------------------------------------------------------------------|
> > >    CAUTION: External Email
> > >
> > > |-------------------------------------------------------------------!
> > >
> > > Hi Lukasz
> > >
> > > On Tue, Aug 18, 2026 at 4:15 PM Lukasz Kornicki
> > > <lucas.kornicki@nutanix.com> wrote:
> > >> Introduce a new vnc message (VNC_MSG_SERVER_QEMU_CLIPBOARD_STATUS) and
> > >> the corresponding feature/encoding.
> > >>
> > >> When a client requests this feature, the server will inform the client
> > >> whether a guest clipboard peer is present. The server will repeat the
> > >> notification each time availability of a guest clipboard peer changes.
> > >>
> > >> This change enables the VNC client to determine if a guest side
> > >> clipboard peer is available for clipboard exchange and react to
> > >> changes of its availability.
> > >>
> > >> Until now the VNC clipboard peer was only registered when
> > >> VNC_FEATURE_CLIPBOARD_EXT was enabled. With this change the VNC peer
> > >> can be registered just for the purpose of receiving peer status
> > >> updates. This requires introducing a VNC_FEATURE_CLIPBOARD_EXT guard
> > >> before the QEMU_CLIPBOARD_UPDATE_INFO handler which previously only ran
> > >> if VNC_FEATURE_CLIPBOARD_EXT was enabled.
> > >>
> > > The series looks good, but this extension is not documented afaict.
> > > Can you make a PR for it?
> >
> > Sure. I've found this repo before but was not aware that it functions in
> > any official capacity.
> 
> I dont think we should take the change until the rfbproto documents it.

Yes, please submit an rfbproto  PR for the extension, as we've tried
to ensure everything QEMU implements is specified there to aid in
future interoperability and to spot design mistakes at spec time.

With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|



  reply	other threads:[~2026-08-24 13:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-18 12:14 [PATCH 0/4] Add clipboard status notification to VNC Lukasz Kornicki
2026-08-18 12:14 ` [PATCH 1/4] ui/clipboard: add clipboard peer update notification Lukasz Kornicki
2026-08-18 12:14 ` [PATCH 2/4] ui/clipboard: keep track of clipboard peer side Lukasz Kornicki
2026-08-18 12:14 ` [PATCH 3/4] ui/vnc-clipboard: factor out clipboard peer registration Lukasz Kornicki
2026-08-18 12:14 ` [PATCH 4/4] ui/vnc: notify client of clipboard peer status Lukasz Kornicki
2026-08-18 13:33   ` Marc-André Lureau
2026-08-18 13:55     ` Lucas Kornicki
2026-08-24 12:36       ` Marc-André Lureau
2026-08-24 13:09         ` Daniel P. Berrangé [this message]
2026-09-01  8:35         ` Lucas Kornicki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aoxCnWc9SOwYOhEK@redhat.com \
    --to=berrange@redhat.com \
    --cc=lucas.kornicki@nutanix.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.