From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C25C6C5DF81 for ; Mon, 24 Aug 2026 13:25:27 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wyUfa-0006O2-Vo; Mon, 24 Aug 2026 09:24:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wyUfa-0006Ne-3W for qemu-devel@nongnu.org; Mon, 24 Aug 2026 09:24:58 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wyUfY-0001am-Be for qemu-devel@nongnu.org; Mon, 24 Aug 2026 09:24:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787577894; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SKjOvZoicChKphtxD3A+94WjTWxBlxp8zJtMRodc/YE=; b=SmfAnxlgZrz8hwiwFW1JQODAG24TyTb0URw1VmNSMjaKNntQIe3DhR9bg5fM1NPYKiNBR3 gADWQWzBbXOZ75Lx4m0Gk4qphzEFJTF513ScmCX2yiz6dPQMbfERFWPMJTC+8dVv70l1it QFoLOpLgODdKxmJiJDLh2GW4DRTA6Cs= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-224-1-Mhse9yMZKC0rOaUPSPKA-1; Mon, 24 Aug 2026 09:24:50 -0400 X-MC-Unique: 1-Mhse9yMZKC0rOaUPSPKA-1 X-Mimecast-MFC-AGG-ID: 1-Mhse9yMZKC0rOaUPSPKA_1787577889 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 041E018301BE; Mon, 24 Aug 2026 13:24:49 +0000 (UTC) Received: from redhat.com (headnet05.pony-001.prod.iad2.dc.redhat.com [10.2.32.117]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 12E0C26C; Mon, 24 Aug 2026 13:24:46 +0000 (UTC) Date: Mon, 24 Aug 2026 14:24:43 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Cc: qemu-devel@nongnu.org, Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Markus Armbruster , "Dr. David Alan Gilbert" Subject: Re: [PATCH v3 08/49] monitor: move HMP-only fields from Monitor to MonitorHMP Message-ID: References: <20260816-qemu-no-hmp-v3-0-e53fc35bc550@redhat.com> <20260816-qemu-no-hmp-v3-8-e53fc35bc550@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260816-qemu-no-hmp-v3-8-e53fc35bc550@redhat.com> User-Agent: Mutt/2.4.0 (2026-06-19) X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Sun, Aug 16, 2026 at 11:12:35PM +0400, Marc-André Lureau wrote: > mon_cpu_path and reset_seen are only used by HMP monitors; move them > from the base Monitor struct into MonitorHMP to properly encapsulate > HMP-specific state. > > Reviewed-by: Philippe Mathieu-Daudé > Signed-off-by: Marc-André Lureau > --- > monitor/hmp-cmds.c | 16 +++++++++------- > monitor/hmp.c | 9 +++++---- > monitor/monitor-internal.h | 4 ++-- > monitor/monitor.c | 1 - > 4 files changed, 16 insertions(+), 14 deletions(-) > > diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c > index 6b1114fdaf13..6718fec97047 100644 > --- a/monitor/hmp-cmds.c > +++ b/monitor/hmp-cmds.c > @@ -499,31 +499,33 @@ void hmp_dumpdtb(Monitor *mon, const QDict *qdict) > /* Set the current CPU defined by the user. Callers must hold BQL. */ > int monitor_set_cpu(Monitor *mon, int cpu_index) > { > + MonitorHMP *hmp_mon = MONITOR_HMP(mon); Nitpicking, 'hmp_mon' is redundant IMHO - 'hmp' is sufficient and used elsewhere in monitor/ code. > CPUState *cpu; > > cpu = qemu_get_cpu(cpu_index); > if (cpu == NULL) { > return -1; > } > - g_free(mon->mon_cpu_path); > - mon->mon_cpu_path = object_get_canonical_path(OBJECT(cpu)); > + g_free(hmp_mon->mon_cpu_path); > + hmp_mon->mon_cpu_path = object_get_canonical_path(OBJECT(cpu)); > return 0; > } None the less Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|