All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephan Gerhold <stephan.gerhold@linaro.org>
To: Linus Walleij <linusw@kernel.org>
Cc: u-boot@lists.u-boot-project.org, Tom Rini <trini@konsulko.com>,
	Stefan Hansson <newbyte@postmarketos.org>
Subject: Re: [PATCH v5 13/13] arm: u8500: Package Stemmy device trees in FIT
Date: Mon, 24 Aug 2026 15:59:41 +0200	[thread overview]
Message-ID: <aoxOTWT8r7QX00lL@linaro.org> (raw)
In-Reply-To: <20260823-ux500-external-sdcard-v5-13-07ca794e2b94@kernel.org>

On Sun, Aug 23, 2026 at 10:39:32PM +0200, Linus Walleij wrote:
> Build all seven supported Samsung Ux500 device trees into the FIT
> appended to U-Boot. Select the appropriate configuration at runtime
> from the machine ID passed by the Samsung firmware. Codina and Codina
> TMO share a machine ID, so distinguish Codina TMO by its board ID.
> 
> Keep a Kconfig default for the generic multi-DTB build dependency, but
> remove it from the defconfig since the board selection is now dynamic.
> Print the firmware machine and board IDs to aid diagnostics and future
> machine ID mappings.
> 
> Signed-off-by: Linus Walleij <linusw@kernel.org>

Yes! This is great, thanks :)

> ---
>  arch/arm/Kconfig          |  1 +
>  board/ste/stemmy/Kconfig  |  6 ++++
>  board/ste/stemmy/stemmy.c | 77 ++++++++++++++++++++++++++++++++++++++++++++---
>  configs/stemmy_defconfig  |  1 -
>  4 files changed, 79 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 2a01ac9b7675..8e697b87d50f 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -1278,6 +1278,7 @@ config ARCH_U8500
>  	imply DM_REGULATOR
>  	imply DM_REGULATOR_FIXED
>  	imply DM_RTC
> +	imply MULTI_DTB_FIT
>  	imply NOMADIK_GPIO
>  	imply NOMADIK_MTU_TIMER
>  	imply PINCTRL

It's a bit weird to have this in ARCH_U8500 since there may be other
(non-Samsung) U8500 boards who couldn't use MULTI_DTB_FIT.

Can you put this into stemmy_defconfig?

> diff --git a/board/ste/stemmy/Kconfig b/board/ste/stemmy/Kconfig
> index b890ba51cb03..e891ddf9f8b2 100644
> --- a/board/ste/stemmy/Kconfig
> +++ b/board/ste/stemmy/Kconfig
> @@ -9,4 +9,10 @@ config SYS_VENDOR
>  config SYS_CONFIG_NAME
>  	default "stemmy"
>  
> +config DEFAULT_DEVICE_TREE
> +	default "st/ste-ux500-samsung-janice"
> +
> +config OF_LIST
> +	default "st/ste-ux500-samsung-codina st/ste-ux500-samsung-codina-tmo st/ste-ux500-samsung-gavini st/ste-ux500-samsung-golden st/ste-ux500-samsung-janice st/ste-ux500-samsung-kyle st/ste-ux500-samsung-skomer"
> +
>  endif

I don't mind adding this here, but I'm also not sure if there is any
advantage compared to adding this directly in stemmy_defconfig?

Thanks,
Stephan

      reply	other threads:[~2026-08-24 13:59 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-23 20:39 [PATCH v5 00/13] arm: u8500: Enable upstream DT based SD card boot Linus Walleij
2026-08-23 20:39 ` [PATCH v5 01/13] pinctrl: Add compact Nomadik pin controller Linus Walleij
2026-08-24 13:17   ` Stephan Gerhold
2026-08-23 20:39 ` [PATCH v5 02/13] mmc: arm_pl180: Configure Ux500 signal direction Linus Walleij
2026-08-23 20:39 ` [PATCH v5 03/13] mmc: arm_pl180: Gate idle card clocks Linus Walleij
2026-08-24 13:25   ` Stephan Gerhold
2026-08-24 19:50     ` Linus Walleij
2026-08-23 20:39 ` [PATCH v5 04/13] power: regulator: Add driver voltage clamp callback Linus Walleij
2026-08-23 20:39 ` [PATCH v5 05/13] mmc: arm_pl180: Set initial supply voltages Linus Walleij
2026-08-23 20:39 ` [PATCH v5 06/13] mmc: arm_pl180: Power down card supplies at OS handoff Linus Walleij
2026-08-24 13:30   ` Stephan Gerhold
2026-08-24 20:01     ` Linus Walleij
2026-08-25  7:43       ` Stephan Gerhold
2026-08-23 20:39 ` [PATCH v5 07/13] power: regulator: Add AB8500 AUX3 support Linus Walleij
2026-08-24 13:45   ` Stephan Gerhold
2026-08-24 20:04     ` Linus Walleij
2026-08-23 20:39 ` [PATCH v5 08/13] arm: u8500: Enable SD card regulators Linus Walleij
2026-08-23 20:39 ` [PATCH v5 09/13] configs: stemmy: Boot EFI from external SD card Linus Walleij
2026-08-24 13:46   ` Stephan Gerhold
2026-08-23 20:39 ` [PATCH v5 10/13] arm: u8500: Switch Stemmy to upstream Janice device tree Linus Walleij
2026-08-24 13:55   ` Stephan Gerhold
2026-08-24 20:21     ` Linus Walleij
2026-08-23 20:39 ` [PATCH v5 11/13] ARM: dts: ux500: Make panel regulators have unique names Linus Walleij
2026-08-23 20:39 ` [PATCH v5 12/13] ARM: dts: ux500: Harmonize GPIO key names Linus Walleij
2026-08-23 20:39 ` [PATCH v5 13/13] arm: u8500: Package Stemmy device trees in FIT Linus Walleij
2026-08-24 13:59   ` Stephan Gerhold [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aoxOTWT8r7QX00lL@linaro.org \
    --to=stephan.gerhold@linaro.org \
    --cc=linusw@kernel.org \
    --cc=newbyte@postmarketos.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.u-boot-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.