From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B0365367281 for ; Mon, 24 Aug 2026 15:14:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787584462; cv=none; b=Y6bvVH4ZSIg/+htmQ4DMxhKdf0OLQ2te3tHNfsiQsPKHAIjrjQbTQOs75BJttuUDBj7vU9fhWG3oLzagJ5aGGTws+AYtaM4qQ8mIMh4b2nkxClurd8NEi4a90XQBmEL5VnvF1r8hE5YiDxEvR3bqUqaB59tKiKEPy17m1XfP8b8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787584462; c=relaxed/simple; bh=PMHzlusqnjEcUolJb6Rj0ihhVcm0EmxTzAkLKIuEEmA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: In-Reply-To:Content-Type:Content-Disposition; b=DKkZou68FZZpBqSP5H+PiemYvVwL1iWdfSATch1ZJMpf77y4vE3Qo63AbZ7QC2/RjzmQxUmeeW9mfulEEtrfvbXr7ZGz6mGMkapHkrggDUDqD5HLP1FcnUwO3AA9LTJBuG6EVtBCDNk/VdASfigIa1cNPaNYvQqonxgFgWLNM/E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=arEZlnlg; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="arEZlnlg" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787584459; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=r9JEBxETCpjKOyzPxUj8DiK5Y8iV5A7DhykNYlgKppA=; b=arEZlnlg4W2uN8jNuObPdV7XEADzujjJXwvcZ0jsYyOs1GpgplUEFL8fS3dR8trvvObtIj bogtbd+W7m+xsHUVN4Gk5Ma9VphbXjVZO5f8hcrXCgQVPh7THWyq/OlM+xHXE2aDqP4kZc OzOCr0NnyCMMjqrNBjxYsN60anza9lc= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-617-CZacIbhKMZ2ecjJg17MVig-1; Mon, 24 Aug 2026 11:14:18 -0400 X-MC-Unique: CZacIbhKMZ2ecjJg17MVig-1 X-Mimecast-MFC-AGG-ID: CZacIbhKMZ2ecjJg17MVig_1787584458 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-90c4da3d504so18776816d6.0 for ; Mon, 24 Aug 2026 08:14:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787584458; x=1788189258; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=r9JEBxETCpjKOyzPxUj8DiK5Y8iV5A7DhykNYlgKppA=; b=N0ibqbHUD20ishbC04SB2hkdEyzEBK3ZoCuwbcSld90c7ITpj1iejrVSvxHvQpbPAy 8JArOWGfhYx8ret6qu7LSoTf7+UNwdryift8Q8vAxvp247VHL4BUtXeLbvKg6xTWGN2B /n1npwruDxUEa3fU2kEwgIb+wrVaFeNld1+ecQSBwOjsZFT32IFkBj82SL8ivBwmyU8F Dq7/RCMBrhJrY7nP9vbRXKEzeszZKC6efiH2/Kaz9l50eJugGj3oijzwqD9YNb4nj6vu Z0h58n29MHwQyt3p+/JVkJLnAOBF/E3Jcgd0zR0zBetY3uiarYImq+IzWb4C/+1VsF8D 20RA== X-Forwarded-Encrypted: i=1; AHgh+RrDNuNZA4wxifSrjvpk6+sH7ESxmaXy2wWXfPNMZhBh3asNGMaB9pC9oHB4sX7h6Pao0eY=@lists.linux.dev X-Gm-Message-State: AFuF++nSjoAht4DUrAt25n5PGccHITvScsJ0ZpPYYcxYZ0+/hyrdABBx FK3XAJvjQNhyXnVZ/tO3vOnnOo+lXUKaxH95mDHCZ4s5ZtZ/8cTC4GPx+fwFbItmV62bATA9C6w UtJykABn1KuPejKi/WYGfYz/NE9hiEloYJTUr0aWEy2BY4StP/CXISw== X-Gm-Gg: AR+sD12nmXT6ju7jYcNO2yJIWdITzz1NrDpfVgBdmXgTIwGYxlcjAMx5AFY5Ng1g51q v5+sFmVLflWrZTg7r/c0Ua0K2R3bn9FWWzexY8VwPxOw8t0CsQfld0+SBW8JhnaBzDfZYQSWtL+ YNK2bm4A2+pQmngYbygmeQToQPLp3WtfRNOWAJRoQMhMXAKzf0DS2Hx7lnUtkCB/xsgQzpX2Ln+ C08IQQomlpCljckg0ZuELAmvBK1RYFMCZX5AvuQizbqCGRPmqTFiJ83hKCOP9cwa7rdF5E3L8bl 5LQ5P/hdqST2QAJgpihn6bdAEdUdHDQBvvlNcSDBZ5XAj7997mrsITns6PwZAVUv+oSrEZgTnt9 i9/McnYYKLnnd3TKtcOBDMYlKfW8XauGpBRk= X-Received: by 2002:a05:6214:2a49:b0:8f1:440c:7f81 with SMTP id 6a1803df08f44-90c80942e22mr260846406d6.4.1787584457453; Mon, 24 Aug 2026 08:14:17 -0700 (PDT) X-Received: by 2002:a05:6214:2a49:b0:8f1:440c:7f81 with SMTP id 6a1803df08f44-90c80942e22mr260845166d6.4.1787584456812; Mon, 24 Aug 2026 08:14:16 -0700 (PDT) Received: from redhat.com (c-73-183-53-213.hsd1.pa.comcast.net. [73.183.53.213]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-90c93a82554sm64013126d6.45.2026.08.24.08.14.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Aug 2026 08:14:15 -0700 (PDT) Date: Mon, 24 Aug 2026 11:14:11 -0400 From: Brian Masney To: Geert Uytterhoeven Cc: Ryan Chen , Joel Stanley , Stephen Boyd , Brian Masney , Jerome Brunet , Andrew Jeffery , Billy Tsai , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Ray Jui , Scott Branden , Broadcom internal kernel review list , Taichi Sugaya , Takao Orito , Linus Walleij , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Sudeep Holla , Cristian Marussi , David Lechner , Abel Vesa , Peng Fan , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Paul Cercueil , Santosh Shilimkar , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Vladimir Zapolskiy , Heiko Stuebner , Krzysztof Kozlowski , Sylwester Nawrocki , Chanwoo Choi , Peter Griffin , Alim Akhtar , Dinh Nguyen , Viresh Kumar , Maxime Coquelin , Alexandre Torgue , Emilio =?iso-8859-1?Q?L=F3pez?= , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Prashant Gaikwad , Thierry Reding , Jonathan Hunter , Kunihiko Hayashi , Masami Hiramatsu , Ulf Hansson , Liviu Dudau , Lorenzo Pieralisi , Michal Simek , Matthias Brugger , linux-clk@vger.kernel.org, linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, arm-scmi@vger.kernel.org, imx@lists.linux.dev, linux-mips@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, soc@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH 00/45] clk: Make sure clk_init_data is fully initialized (part two) Message-ID: References: Precedence: bulk X-Mailing-List: soc@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/2.4.0 (2026-06-19) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: tV-ymX4OtzCPeAuNMp2_0YPo3HwmsFq26pwnsVUD4qA_1787584458 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Aug 21, 2026 at 10:53:10AM +0200, Geert Uytterhoeven wrote: > Hi all, > > The clk_init_data structure contains several mutually-exclusive members > for different methods to specify the possible parents of a clock, > prompting drivers to initialize only the members they need. However, > not initializing all members may cause subtle issues, which are only > exposed when CONFIG_INIT_STACK_ALL_PATTERN or CONFIG_INIT_STACK_NONE is > enabled. > > Hence this series aims to make sure all members are fully initialized, > to avoid such bugs, and to prevent future breakage when converting > drivers to a different method for specifying the parents. > > Part One[1] fixed all cases that I identified to be real bugs, in > response to a crash I saw on BeagleBone Black. > > This series is the clock subpart of Part Two, which fixes remaining > cases that are currently harmless. These are still fragile, and may > cause future breakage when converting drivers to a different method for > specifying the parents. > > Thanks for your comments! > > [1] "[PATCH treewide 0/5] clk: Make sure clk_init_data is fully > initialized (part 1)" > https://lore.kernel.org/cover.1787165329.git.geert+renesas@glider.be Thanks for cleaning this all up! For the series: Reviewed-by: Brian Masney