From: Stefano Radaelli <stefano.radaelli21@gmail.com>
To: sashiko-reviews@lists.linux.dev
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org,
Frank.Li@kernel.org, imx@lists.linux.dev
Subject: Re: [PATCH v3 2/3] ARM: dts: imx7d: add Variscite VAR-SOM-MX7 support
Date: Mon, 24 Aug 2026 17:41:02 +0200 [thread overview]
Message-ID: <aoxmDpCMITmyuHHO@GLaDOS.station> (raw)
In-Reply-To: <20260824153400.119F61F000E9@smtp.kernel.org>
On Mon, Aug 24, 2026 at 03:33:59PM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 4 potential issue(s) to consider:
> - [High] The ads7846 touchscreen specifies an active-high GPIO for pendown, which conflicts with its active-low interrupt and breaks touch detection.
> - [High] The V1 hardware WiFi regulator (`reg_vmmc_wl`) lacks a `gpio` property and relies on a userspace script to enable WiFi power, breaking automatic device probing.
> - [Medium] The `wm8904` codec's `IN1L` pin is configured as a digital microphone input but is simultaneously routed to an analog 'Microphone Jack' in the DAPM topology.
> - [Low] Non-generic node names and invalid characters are used for the touchscreen, audio codec devices, and regulators.
I'm going to fix these errors.
Stefano
next prev parent reply other threads:[~2026-08-24 15:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-24 15:08 [PATCH v3 0/3] Add support for Variscite VAR-SOM-MX7 and MX7CustomBoard Stefano Radaelli
2026-08-24 15:08 ` [PATCH v3 1/3] dt-bindings: arm: fsl: add Variscite VAR-SOM-MX7 boards Stefano Radaelli
2026-08-24 15:08 ` [PATCH v3 2/3] ARM: dts: imx7d: add Variscite VAR-SOM-MX7 support Stefano Radaelli
2026-08-24 15:33 ` sashiko-bot
2026-08-24 15:41 ` Stefano Radaelli [this message]
2026-08-24 15:08 ` [PATCH v3 3/3] ARM: dts: imx7d: add Variscite MX7CustomBoard support Stefano Radaelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aoxmDpCMITmyuHHO@GLaDOS.station \
--to=stefano.radaelli21@gmail.com \
--cc=Frank.Li@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.