Re: [PATCH 1/2] drm/xe/i2c: Not for review, Squash of I2C/AMC series

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Mon, Aug 24, 2026 at 10:33:23PM +0530, Nilawar, Badal wrote:
> 
> On 24-08-2026 17:57, Heikki Krogerus wrote:
> > On Sun, Aug 23, 2026 at 04:05:25PM +0530, Badal Nilawar wrote:
> > > From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> > This patch is not from me.
> > 
> > > Squash of https://patchwork.freedesktop.org/series/168930/
> > Why? What are you trying to achieve with this patch??????
> To unblock the development I squashed your patches and built patch 2 on the
> top of it.
> > 
> > > Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> > Do not use my signature!
> > 
> > It does not matter that the code originates from me - you can express
> > that in a different way in the commit message. You don't use other
> > peoples' signature even if the patch was intended for development
> > purposes only.
> 
> Sure, understood. I did not think it was appropriate to change the
> authorship, so I kept the original authorship intact and explicitly marked
> the series as "Not for review" in the commit message.
> 
> I think I should have dropped your Signed-off-by.

Please always remember that sign-off != authorship! A pretty common misunderstood.

And whenever doing this kind of squash for CI make sure that the commit message
needs to be pretty clear of the intent and with lore URLs for the original work
where the review of that needs to continue.

Thanks,
Rodrigo.

> 
> Thanks,
> Badal
> 
> > 
> > Thanks,
> >