From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Shubham Chakraborty <chakrabortyshubham66@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2] package/tcl: bump to version 9.0.3
Date: Mon, 24 Aug 2026 22:24:41 +0200 [thread overview]
Message-ID: <aoyoCY6c2qTJcRxz@windsurf> (raw)
In-Reply-To: <20260810113154.1955756-1-chakrabortyshubham66@gmail.com>
Hello,
On Mon, Aug 10, 2026 at 05:01:52PM +0530, Shubham Chakraborty wrote:
> -TCL_VERSION_MAJOR = 8.6
> -TCL_VERSION = $(TCL_VERSION_MAJOR).15
> +TCL_VERSION_MAJOR = 9.0
> +TCL_VERSION = $(TCL_VERSION_MAJOR).3
> TCL_SOURCE = tcl$(TCL_VERSION)-src.tar.gz
> TCL_SITE = http://downloads.sourceforge.net/project/tcl/Tcl/$(TCL_VERSION)
> TCL_LICENSE = TCL
> @@ -73,9 +73,19 @@ define TCL_REMOVE_EXTRA
> endef
> TCL_POST_INSTALL_TARGET_HOOKS += TCL_REMOVE_EXTRA
>
> +define HOST_TCL_SYMLINK_TCLSH
> + ln -sf tclsh$(TCL_VERSION_MAJOR) $(HOST_DIR)/bin/tclsh
> +endef
> +HOST_TCL_POST_INSTALL_HOOKS += HOST_TCL_SYMLINK_TCLSH
Are you sure you need to symlink, since...
> +
> +TCL_MAKE_OPTS = \
> + TCLSH="$(HOST_DIR)/bin/tclsh$(TCL_VERSION_MAJOR)" \
> + TCLSH_PROG="$(HOST_DIR)/bin/tclsh$(TCL_VERSION_MAJOR)"
... you're passing the full path to
$(HOST_DIR)/bin/tclsh$(TCL_VERSION_MAJOR) here?
From my quick experiment, it seems like the symlink is not needed.
Also, could you verify that both TCLSH= and TCLSH_PROG= are needed?
> +
> TCL_DEPENDENCIES = $(if $(BR2_PACKAGE_SQLITE),sqlite) \
> $(if $(BR2_PACKAGE_MARIADB),mariadb) \
> $(if $(BR2_PACKAGE_POSTGRESQL),postgresql) \
> + host-tcl \
> zlib
With your patch:
- host-tcl fails to build because <zlib.h> is not found. Seems like
host-zlib is now needed as a dependency of host-tcl. Make sure to
build in a minimal Docker container to figure out this kind of
issue. You can trivially do that in Buildroot: "./utils/docker-run
make".
- tcllib fails to build, because version 1.21 is not designed to work
with Tcl 9.0, you need to bump tcllib to 2.0 apparently.
Could you look into these different issues, and get back to us with an
updated patch?
Thanks a lot!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2026-08-24 20:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-03 8:12 [Buildroot] [PATCH] package/tcl: bump to version 9.0.3 Shubham Chakraborty
2026-05-31 6:11 ` Thomas Petazzoni via buildroot
2026-08-10 11:31 ` [Buildroot] [PATCH v2] " Shubham Chakraborty
2026-08-24 20:24 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aoyoCY6c2qTJcRxz@windsurf \
--to=buildroot@buildroot.org \
--cc=chakrabortyshubham66@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.