From: Vincent Jardin <vjardin@free.fr>
To: sashiko-reviews@lists.linux.dev
Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
conor+dt@kernel.org, robh@kernel.org
Subject: Re: [PATCH] dt-bindings: hwmon: ti,tmp401: add vcc-supply and #thermal-sensor-cells
Date: Tue, 25 Aug 2026 00:09:14 +0200 [thread overview]
Message-ID: <aozBCv7L_Hk81Rx8@L30177.local> (raw)
In-Reply-To: <20260824155758.CD2F11F000E9@smtp.kernel.org>
Hi Bot,
Le 24/08/26 15:57, sashiko-bot@kernel.org a écrit :
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] The commit message contains a major factual error: it justifies adding the `vcc-supply` property by claiming it is fetched by `lm90_probe()` in `drivers/hwmon/lm90.c`, but the `ti,tmp401` and `ti,tmp411` devices are actually backed by `drivers/hwmon/tmp401.c`, which completely lacks regulator support.
You have the points.
The vcc-supply justification in the commit message is wrong assuption for
this device.
v2 will drop vcc-supply and it will keep only #thermal-sensor-cells.
The #thermal-sensor-cells topics is better explained in v2.
Thanks for the review,
Vincent
prev parent reply other threads:[~2026-08-24 22:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-24 15:46 [PATCH] dt-bindings: hwmon: ti,tmp401: add vcc-supply and #thermal-sensor-cells Vincent Jardin via B4 Relay
2026-08-24 15:46 ` Vincent Jardin
2026-08-24 15:57 ` sashiko-bot
2026-08-24 22:09 ` Vincent Jardin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aozBCv7L_Hk81Rx8@L30177.local \
--to=vjardin@free.fr \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.