From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org, Zhiling Zou <zhilinz@nebusec.ai>
Subject: Re: [PATCH nf-next] netfilter: x_tables: reject missing '-p' flag and check for INV flag
Date: Tue, 25 Aug 2026 00:18:12 +0200 [thread overview]
Message-ID: <aozDJO7EMyfuupGq@strlen.de> (raw)
In-Reply-To: <aoy977yxzSEsViun@strlen.de>
Florian Westphal <fw@strlen.de> wrote:
> > Userspace always provides a zeroed e->ipv6.proto when unused, correct?
>
> Yes, ip6tables raises it when it parses '-p' option.
>
> > If so, LGTM.
>
> Alright, I will respin tomorrow, thanks.
>
> Do you want me to include the TPROXY fix too?
Actually nft_compat.c already does:
if (proto)
entry->e6.ipv6.flags |= IP6T_F_PROTO;
so the only other necessary fix is the check for 'INV' in xt_l2tp.c.
next prev parent reply other threads:[~2026-08-24 22:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-21 13:41 [PATCH nf-next] netfilter: x_tables: reject missing '-p' flag and check for INV flag Florian Westphal
2026-08-21 14:02 ` Pablo Neira Ayuso
2026-08-22 8:14 ` Florian Westphal
2026-08-24 21:50 ` Pablo Neira Ayuso
2026-08-24 21:55 ` Florian Westphal
2026-08-24 22:18 ` Florian Westphal [this message]
2026-08-24 22:24 ` Pablo Neira Ayuso
2026-08-24 22:23 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aozDJO7EMyfuupGq@strlen.de \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=zhilinz@nebusec.ai \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.