From: Vinod Koul <vkoul@kernel.org>
To: "Pandey, Radhey Shyam" <radheys@amd.com>
Cc: dmaengine@vger.kernel.org, Frank Li <Frank.Li@kernel.org>
Subject: Re: [PATCH] dmaengine: zynqmp_dma: drop redundant label
Date: Mon, 7 Sep 2026 12:56:59 +0530 [thread overview]
Message-ID: <ap5nQ1Q7s6RbdoUj@parshuram> (raw)
In-Reply-To: <ac8ea7c9-2c6f-422a-a741-7829c77d7c00@amd.com>
On 06-09-26, 16:49, Pandey, Radhey Shyam wrote:
> On 9/5/2026 9:01 PM, Pandey, Radhey Shyam wrote:
> > On 9/3/2026 10:33 PM, Vinod Koul wrote:
> > > Commit 64c6f7da8c2c ("dmaengine: zynqmp_dma: Add runtime pm support")
> > > dropped the use of err_disable_pm label causing warning:
> > >
> > > drivers/dma/xilinx/zynqmp_dma.c: In function ‘zynqmp_dma_probe’:
> > > drivers/dma/xilinx/zynqmp_dma.c:1171:1: error: label
> > > ‘err_disable_pm’ defined but not used [-Werror=unused-label]
> > > 1171 | err_disable_pm:
> > >
> > > Drop it
> > >
> > > Fixes: 64c6f7da8c2c ("dmaengine: zynqmp_dma: Add runtime pm support")
> >
> > Seems Fixes tag is incorrect.
> > Fixes: 3f30db282c28 ("dmaengine: zynqmp_dma: Fix chan probe/remove error
> > handling")
> >
> > Rest looks fine to me.
> > Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
> > Thanks!
>
> Just a thought - this bug is present in dmaengine/next and if it isn't
> pushed to external we can squash this patch to fixes commit itself (if
> rebase on next is possible)?
Yes this is for a patch I applied and found while building. So will
apply this...
--
~Vinod
next prev parent reply other threads:[~2026-09-07 7:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-03 17:03 [PATCH] dmaengine: zynqmp_dma: drop redundant label Vinod Koul
2026-09-03 17:11 ` sashiko-bot
2026-09-03 19:01 ` Frank Li
2026-09-05 15:31 ` Pandey, Radhey Shyam
2026-09-06 11:19 ` Pandey, Radhey Shyam
2026-09-07 7:26 ` Vinod Koul [this message]
2026-09-07 13:47 ` Vinod Koul
2026-09-07 13:56 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ap5nQ1Q7s6RbdoUj@parshuram \
--to=vkoul@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=radheys@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.