From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 42A83C79F9E for ; Mon, 7 Sep 2026 09:45:18 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x3Vu2-0005JI-KT; Mon, 07 Sep 2026 05:44:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x3Vu1-0005Io-5W for qemu-arm@nongnu.org; Mon, 07 Sep 2026 05:44:37 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x3Vtz-0004nY-1J for qemu-arm@nongnu.org; Mon, 07 Sep 2026 05:44:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788774273; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dSPfv15qL1Yu1YP0Q4NmmJHQxH/QUplh4FAuZDmeki4=; b=K4KMzbOnQIf/GE5t5moCi+ja5U/YQM5FvffOYLeHTeMKFRRIDY4fjfeHY/dc4FDSOJFYf0 HULki7NwLaW12ngV5y4RwVFK+8xUXdEvkY7duM+vuozKdIoHB5QG6nxjOgQTo3rGWSecj+ qm9RU9cREq7+4vkKvW31GlVFW7f2BRw= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-446-CDhQMnFwNmKOdsh6hJsVAg-1; Mon, 07 Sep 2026 05:44:30 -0400 X-MC-Unique: CDhQMnFwNmKOdsh6hJsVAg-1 X-Mimecast-MFC-AGG-ID: CDhQMnFwNmKOdsh6hJsVAg_1788774268 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8A5D419539A0; Mon, 7 Sep 2026 09:44:27 +0000 (UTC) Received: from redhat.com (headnet05.pony-001.prod.iad2.dc.redhat.com [10.2.32.117]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7E5EE1800577; Mon, 7 Sep 2026 09:44:22 +0000 (UTC) Date: Mon, 7 Sep 2026 10:44:19 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Cc: qemu-devel@nongnu.org, John Snow , "Denis V. Lunev" , Fabiano Rosas , Laurent Vivier , Paolo Bonzini , qemu-block@nongnu.org, Peter Maydell , Thomas Huth , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Aurelien Jarno , qemu-arm@nongnu.org, Halil Pasic , Christian Borntraeger , Eric Farman , Matthew Rosato , Cornelia Huck , qemu-s390x@nongnu.org, Glenn Miles , qemu-ppc@nongnu.org Subject: Re: [PATCH 6/9] tests/drive_del-test: compile out HMP-dependent tests when !CONFIG_HMP Message-ID: References: <20260906-nohmp-v1-0-daee96491c43@redhat.com> <20260906-nohmp-v1-6-daee96491c43@redhat.com> MIME-Version: 1.0 In-Reply-To: <20260906-nohmp-v1-6-daee96491c43@redhat.com> User-Agent: Mutt/2.4.0 (2026-06-19) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-MFC-PROC-ID: 1_rfgQkJeK4Brn1qP4_wdwnijjmYcToOoQLvw5D0Jdw_1788774268 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org On Sun, Sep 06, 2026 at 12:42:37PM +0400, Marc-André Lureau wrote: > The compiled-out functions are actually testing HMP-specific commands > and behaviour which operate on the old "drive" concept. The QMP > equivalent for block-driver nodes are already tested. > > If HMP goes away, those tests should go away too. Compile them out. > > Signed-off-by: Marc-André Lureau > --- > tests/qtest/drive_del-test.c | 47 +++++++++++++++++++++----------------------- > 1 file changed, 22 insertions(+), 25 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|