From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AB3EFC79F9E for ; Mon, 7 Sep 2026 09:51:31 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x3W0U-0008Lk-5X; Mon, 07 Sep 2026 05:51:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x3W0T-0008LP-Cc for qemu-arm@nongnu.org; Mon, 07 Sep 2026 05:51:17 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x3W0R-0005tE-9u for qemu-arm@nongnu.org; Mon, 07 Sep 2026 05:51:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788774674; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yP06WkixExfVKgOlDFVEvkXrO0xLPs9obVvyFK9bel4=; b=hMiREbNGJHlOcEswdHuYCHyp8GC2Qbtza0tBh/ThKSLEtljhcoj6gsouUHBe4ciYXcZhcm kbcUQgFdKsjoLWDsS69a4u7KHHl0peOSHJBjur8UhIVfE9vcJPgeGRZfjzQqFKcXe4dvtr 88nuGvbrOniil+WTrCMJgpM+wXxPkag= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-491-XSrQ0G3SMse9EZxpt1hvpw-1; Mon, 07 Sep 2026 05:51:10 -0400 X-MC-Unique: XSrQ0G3SMse9EZxpt1hvpw-1 X-Mimecast-MFC-AGG-ID: XSrQ0G3SMse9EZxpt1hvpw_1788774668 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1F26F195422C; Mon, 7 Sep 2026 09:51:08 +0000 (UTC) Received: from redhat.com (headnet05.pony-001.prod.iad2.dc.redhat.com [10.2.32.117]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id DD9D930002F0; Mon, 7 Sep 2026 09:51:02 +0000 (UTC) Date: Mon, 7 Sep 2026 10:50:59 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Cc: qemu-devel@nongnu.org, John Snow , "Denis V. Lunev" , Fabiano Rosas , Laurent Vivier , Paolo Bonzini , qemu-block@nongnu.org, Peter Maydell , Thomas Huth , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Aurelien Jarno , qemu-arm@nongnu.org, Halil Pasic , Christian Borntraeger , Eric Farman , Matthew Rosato , Cornelia Huck , qemu-s390x@nongnu.org, Glenn Miles , qemu-ppc@nongnu.org Subject: Re: [PATCH 4/9] tests/qtest: add qtest_qmp_job_wait() Message-ID: References: <20260906-nohmp-v1-0-daee96491c43@redhat.com> <20260906-nohmp-v1-4-daee96491c43@redhat.com> MIME-Version: 1.0 In-Reply-To: <20260906-nohmp-v1-4-daee96491c43@redhat.com> User-Agent: Mutt/2.4.0 (2026-06-19) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-MFC-PROC-ID: zau5OqGjRBMJv5Ybatv2cNQtpDeOdRJO3emo1B5dEx4_1788774668 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.01, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org On Sun, Sep 06, 2026 at 12:42:35PM +0400, Marc-André Lureau wrote: > Add a helper to wait for job conclusion, used in next changes. > > Signed-off-by: Marc-André Lureau > --- > tests/qtest/libqtest.c | 37 +++++++++++++++++++++++++++++++++++++ > tests/qtest/libqtest.h | 11 +++++++++++ > 2 files changed, 48 insertions(+) > > diff --git a/tests/qtest/libqtest.c b/tests/qtest/libqtest.c > index 28bb72bfaecf..370f79a3b6fb 100644 > --- a/tests/qtest/libqtest.c > +++ b/tests/qtest/libqtest.c > @@ -984,6 +984,43 @@ void qtest_qmp_eventwait(QTestState *s, const char *event) > qobject_unref(response); > } > > +void qtest_qmp_job_wait(QTestState *s, const char *job_id) > +{ > + QDict *response, *data, *error; > + QList *jobs; > + const QListEntry *entry; > + > + for (;;) { > + response = qtest_qmp_eventwait_ref(s, "JOB_STATUS_CHANGE"); > + data = qdict_get_qdict(response, "data"); > + if (!strcmp(qdict_get_str(data, "id"), job_id) && > + !strcmp(qdict_get_str(data, "status"), "concluded")) { > + qobject_unref(response); > + break; > + } > + qobject_unref(response); > + } > + > + response = qtest_qmp(s, "{ 'execute': 'query-jobs' }"); > + g_assert(qdict_haskey(response, "return")); > + jobs = qobject_to(QList, qdict_get(response, "return")); > + g_assert(jobs); > + QLIST_FOREACH_ENTRY(jobs, entry) { > + QDict *job = qobject_to(QDict, qlist_entry_obj(entry)); > + if (!strcmp(qdict_get_str(job, "id"), job_id)) { > + g_assert_null(qdict_get_try_str(job, "error")); If "job" did contain "error", then wouldn't we have hit a SEGV in the qdict_get_str() call due to missing 'id' field. IOW, we should likely validate this is NOT an error response first. > + break; > + } > + } > + qobject_unref(response); > + > + response = qtest_qmp(s, > + "{ 'execute': 'job-dismiss', 'arguments': { 'id': %s } }", job_id); > + error = qdict_get_qdict(response, "error"); > + g_assert_null(error); > + qobject_unref(response); > +} > + With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|