All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lukas Wunner <lukas@wunner.de>
To: Alexander Fischer <alexander.fischer@kait2en.org>
Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	"Jani Nikula" <jani.nikula@linux.intel.com>,
	"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
	"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
	"Tvrtko Ursulin" <tursulin@ursulin.net>,
	"David Airlie" <airlied@gmail.com>,
	"Simona Vetter" <simona@ffwll.ch>,
	"José Roberto de Souza" <jose.souza@intel.com>,
	"André Eikmeyer" <andre.eikmeyer@kait2en.org>,
	"Yossef Osman" <yossef.osman@proton.me>
Subject: Re: [PATCH v2] drm/i915/psr: enable PSR on Apple T2 eDP panels
Date: Mon, 7 Sep 2026 14:14:31 +0200	[thread overview]
Message-ID: <ap6qp8Ct7aLQJhmx@wunner.de> (raw)
In-Reply-To: <20260907083753.41393-1-alexander.fischer@kait2en.org>

On Mon, Sep 07, 2026 at 10:37:53AM +0200, Alexander Fischer wrote:
> @@ -286,6 +306,14 @@ static const struct intel_dpcd_quirk intel_dpcd_quirks[] = {
>  		.sink_oui = SINK_OUI(0x00, 0x22, 0xb9),
>  		.hook = quirk_disable_edp_panel_replay,
>  	},
> +	/* Apple T2 eDP panels */
> +	{
> +		.device = DEVICE_ID_ANY,
> +		.subsystem_vendor = PCI_ANY_ID,
> +		.subsystem_device = PCI_ANY_ID,
> +		.sink_oui = SINK_OUI(0x00, 0x10, 0xfa),
> +		.hook = quirk_apple_psr_handshake,
> +	},
>  };

Looking at lspci output of the MacBookPro16,2 and MacBookPro15,4,
I note that the integrated GPU has Subsystem Vendor 0x106b.
So you could use ".subsystem_vendor = PCI_VENDOR_ID_APPLE,"
to bail out early from the for-loop in intel_init_dpcd_quirks().

Thanks,

Lukas

  reply	other threads:[~2026-09-07 12:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-29 16:16 [PATCH] drm/i915/psr: enable PSR on Apple T2 eDP panels Alexander Fischer
2026-08-31  7:19 ` Lukas Wunner
2026-08-31 11:01   ` Alexander Fischer
2026-08-31 15:02 ` ✗ LGCI.VerificationFailed: failure for " Patchwork
2026-08-31 15:20 ` Patchwork
2026-09-07  8:37 ` [PATCH v2] " Alexander Fischer
2026-09-07 12:14   ` Lukas Wunner [this message]
2026-09-07  8:52 ` ✗ LGCI.VerificationFailed: failure for drm/i915/psr: enable PSR on Apple T2 eDP panels (rev2) Patchwork
2026-09-07 10:09 ` Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ap6qp8Ct7aLQJhmx@wunner.de \
    --to=lukas@wunner.de \
    --cc=airlied@gmail.com \
    --cc=alexander.fischer@kait2en.org \
    --cc=andre.eikmeyer@kait2en.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=jose.souza@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rodrigo.vivi@intel.com \
    --cc=simona@ffwll.ch \
    --cc=tursulin@ursulin.net \
    --cc=yossef.osman@proton.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.