From: "Jörg Rödel" <joro@8bytes.org>
To: Vasant Hegde <vasant.hegde@amd.com>
Cc: iommu@lists.linux.dev, will@kernel.org, robin.murphy@arm.com,
suravee.suthikulpanit@amd.com, Max Zhen <max.zhen@amd.com>,
Liang Wendy <Wendy.Liang@amd.com>
Subject: Re: [PATCH] iommu/amd: Remove iommu_group_mutex_assert() from amd_iommu_clear_gcr3()
Date: Mon, 7 Sep 2026 14:28:23 +0200 [thread overview]
Message-ID: <ap6tleS-DuRr7OOT@8bytes.org> (raw)
In-Reply-To: <20260814104029.71021-1-vasant.hegde@amd.com>
On Fri, Aug 14, 2026 at 10:40:29AM +0000, Vasant Hegde wrote:
> Remove the iommu_group_mutex_assert() call from
> amd_iommu_clear_gcr3(), since PASID teardown via the mmu_notifier
> release path is a legitimate caller that does not and need not hold
> the group mutex.
Jason is right, there is a race around pasid_cnt. Either make that atomic, or,
since it is never read, remove it.
-Joerg
prev parent reply other threads:[~2026-09-07 12:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-14 10:40 [PATCH] iommu/amd: Remove iommu_group_mutex_assert() from amd_iommu_clear_gcr3() Vasant Hegde
2026-08-17 13:51 ` Jason Gunthorpe
2026-09-07 12:28 ` Jörg Rödel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ap6tleS-DuRr7OOT@8bytes.org \
--to=joro@8bytes.org \
--cc=Wendy.Liang@amd.com \
--cc=iommu@lists.linux.dev \
--cc=max.zhen@amd.com \
--cc=robin.murphy@arm.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=vasant.hegde@amd.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.