From: "Jörg Rödel" <joro@8bytes.org>
To: Vasant Hegde <vasant.hegde@amd.com>
Cc: iommu@lists.linux.dev, will@kernel.org, robin.murphy@arm.com,
suravee.suthikulpanit@amd.com, Andreas Juch <andreas@juch.cc>
Subject: Re: [PATCH rc] iommu/amd: Fix premature break in init_iommu_one() again
Date: Mon, 7 Sep 2026 14:50:30 +0200 [thread overview]
Message-ID: <ap6zBdVkaPBKGgtK@8bytes.org> (raw)
In-Reply-To: <20260824062907.4926-1-vasant.hegde@amd.com>
On Mon, Aug 24, 2026 at 06:29:07AM +0000, Vasant Hegde wrote:
> Commit 283d245468a2 ("iommu/amd: Fix premature break in
> init_iommu_one()") unintentionally broke older platforms - such as
> the ASRockRack B550D4-4L - where the BIOS advertises incorrect IOMMU
> features.
>
> Move the HATDis check ahead of the GASup check, and re-introduce the
> break inside the GASup check to restore correct behavior on affected
> platforms.
>
> This is a short-term fix to resolve the regression. Longer term, we
> should rework how EFRs are tracked and prioritize the MMIO-advertised
> EFR over the one reported via IVRS. That requires more extensive
> changes and will be addressed separately.
>
> Fixes: 283d245468a2 ("iommu/amd: Fix premature break in init_iommu_one()")
> Reported-by: Andreas Juch <andreas@juch.cc>
> Closes: https://lore.kernel.org/linux-iommu/07b2d390-f7a0-47e2-bc2c-eb0853acf52e@juch.cc/
> Tested-by: Andreas Juch <andreas@juch.cc>
> Signed-off-by: Vasant Hegde <vasant.hegde@amd.com>
> ---
> drivers/iommu/amd/init.c | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
Queued for -rc, thanks.
prev parent reply other threads:[~2026-09-07 12:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-24 6:29 [PATCH rc] iommu/amd: Fix premature break in init_iommu_one() again Vasant Hegde
2026-09-07 12:50 ` Jörg Rödel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ap6zBdVkaPBKGgtK@8bytes.org \
--to=joro@8bytes.org \
--cc=andreas@juch.cc \
--cc=iommu@lists.linux.dev \
--cc=robin.murphy@arm.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=vasant.hegde@amd.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.