All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gao Xiang <xiang@kernel.org>
To: Jonathan Calmels <jcalmels@nvidia.com>
Cc: linux-erofs@lists.ozlabs.org, Gao Xiang <xiang@kernel.org>
Subject: Re: [PATCH] erofs-utils: lib: refresh device table slots on incremental builds
Date: Tue, 8 Sep 2026 01:00:56 +0800	[thread overview]
Message-ID: <ap7tyB-Nv_BhPU4d@XiangdeMacBook-Pro.local> (raw)
In-Reply-To: <20260903232109.1198449-1-jcalmels@nvidia.com>

Hi Jonathan,

On Thu, Sep 03, 2026 at 04:21:14PM -0700, Jonathan Calmels wrote:
> When --incremental=data is run on a merged image, erofs_write_device_table()
> leaves unified addresses and total block count stale after the primary device
> grows. Fix it by rewriting the slots in place with updated uniaddr value.
> 
> Reproducer:
> 
> mkfs.erofs -Enoinline_data a.erofs a/
> mkfs.erofs -Enoinline_data b.erofs b/
> mkfs.erofs merged.erofs a.erofs b.erofs
> mkfs.erofs --incremental=data merged.erofs c/
> 
> Signed-off-by: Jonathan Calmels <jcalmels@nvidia.com>

Sorry for the delay. I've applied with minor changes.

Also it'd be better to have some basic functionality test case
targeting for experimental-tests.

Thanks,
Gao Xiang


      reply	other threads:[~2026-09-07 17:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-03 23:21 [PATCH] erofs-utils: lib: refresh device table slots on incremental builds Jonathan Calmels
2026-09-07 17:00 ` Gao Xiang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ap7tyB-Nv_BhPU4d@XiangdeMacBook-Pro.local \
    --to=xiang@kernel.org \
    --cc=jcalmels@nvidia.com \
    --cc=linux-erofs@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.