All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@kernel.org>
To: John Ogness <john.ogness@linutronix.de>
Cc: "Petr Mladek" <pmladek@suse.com>,
	"Jon Hunter" <jonathanh@nvidia.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Jiri Slaby" <jirislaby@kernel.org>,
	"Andy Shevchenko" <andy.shevchenko@gmail.com>,
	"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
	linux-kernel@vger.kernel.org,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Hugo Villeneuve" <hvilleneuve@dimonoff.com>,
	"Kees Cook" <kees@kernel.org>,
	"Stepan Ionichev" <sozdayvek@gmail.com>,
	"Xin Zhao" <jackzxcui1989@163.com>,
	"Osama Abdelkader" <osama.abdelkader@gmail.com>,
	"Fushuai Wang" <wangfushuai@baidu.com>,
	"Marco Felsch" <m.felsch@pengutronix.de>,
	linux-serial@vger.kernel.org,
	"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH tty v11 1/2] serial: 8250: Switch to nbcon console, take 2
Date: Thu, 27 Aug 2026 11:45:27 +0200	[thread overview]
Message-ID: <apAEsebh17YagOsa@orome> (raw)
In-Reply-To: <87a4qh9gyk.fsf@jogness.linutronix.de>

[-- Attachment #1: Type: text/plain, Size: 2077 bytes --]

On Thu, Aug 20, 2026 at 01:26:03PM +0206, John Ogness wrote:
> On 2026-08-18, Petr Mladek <pmladek@suse.com> wrote:
> >> [0] https://pastebin.com/FhQVSqfy
> 
> ...
> 
> > Almost everything works as expected except for:
> >
> >   1. I am not sure why "printk: console [ttyS0] disabled" is printed.
> >      It does not make any sense to me.
> 
> I have seen this in the past. It can happens unregister_console_locked()
> has always printed the disabled message before actually checking if the
> console is registered.
> 
> IIRC it has something to do with serial8250_register_8250_port() calling
> uart_remove_one_port(). I remember starting to look into how to fix it
> but then was going down a rabbit hole that exceeded my scope at the
> time.
> 
> >   2. The WARNING would be handled with NBCON_PRIO_EMERGENCY.
> >      I wonder if this warning happened also with "v5" of this
> >      patchset.
> 
> The tegra issue we had with v5 was related to irqwork being scheduled
> when suspending. When keep_bootcon is specified, there will be no
> irqwork scheduled during boot because legacy_direct=true.
> 
> From the backtrace in the posted boot log we see that the warning is
> within tegra_pmc_enter_suspend_mode(). I am wondering if this is the
> same issue we saw with v5... an irqwork getting scheduled when the tegra
> is entering some suspend state.

You mentioning tegra_pmc_enter_suspend_mode() jogged a memory. We have
to play some weird cpuidle tricks when PCI interrupts are anebled
because of a hardware bug. That bug, as far as I know, is only Tegra20
specific, so it doesn't explain this. In this particular case we're also
not talking about PCI in this case, *but* I wonder if there's maybe
other IRQ issues related to cpuidle.

It's a bit of a shot in the dark, but we could try disabling the various
suspend modes via the PMC DT node. Notably LP2 seems to be the one
that's causing issues on Tegra20 with PCI, so maybe changing
nvidia,suspend-mode to something like 0 or 1 would help narrow things
down?

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2026-08-27  9:45 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-29 12:04 [PATCH tty v11 0/2] Convert 8250 to NBCON, take 2 John Ogness
2026-07-29 12:04 ` [PATCH tty v11 1/2] serial: 8250: Switch to nbcon console, " John Ogness
2026-07-29 12:44   ` John Ogness
2026-07-30 14:24   ` Petr Mladek
2026-07-31  7:48     ` John Ogness
2026-07-31 14:04       ` Petr Mladek
2026-08-18  6:25   ` Jon Hunter
2026-08-18  7:01     ` Sebastian Andrzej Siewior
2026-08-18  7:51     ` Petr Mladek
2026-08-18 12:19       ` Jon Hunter
2026-08-18 15:53         ` Petr Mladek
2026-08-20  9:15           ` Jon Hunter
2026-08-20 12:40             ` John Ogness
2026-08-20 23:37               ` Jon Hunter
2026-08-22  0:32                 ` John Ogness
2026-08-24 21:26                   ` Jon Hunter
2026-08-25 13:58                     ` John Ogness
2026-08-25 15:35                       ` Jon Hunter
2026-08-25 22:02                         ` John Ogness
2026-08-26  7:35                           ` Petr Mladek
2026-08-26  7:59                             ` Sebastian Andrzej Siewior
2026-08-27 12:59                               ` John Ogness
2026-08-27 14:49                                 ` Jon Hunter
2026-08-27 15:48                                   ` John Ogness
2026-08-26 14:17                           ` Jon Hunter
2026-08-20 11:20           ` John Ogness
2026-08-27  9:45             ` Thierry Reding [this message]
2026-08-27 14:29               ` Jon Hunter
2026-07-29 12:04 ` [PATCH tty v11 2/2] Revert "serial: 8250: drop lockdep annotation from serial8250_clear_IER()" John Ogness
2026-07-30 14:48 ` [PATCH tty v11 0/2] Convert 8250 to NBCON, take 2 Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=apAEsebh17YagOsa@orome \
    --to=thierry.reding@kernel.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=bigeasy@linutronix.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=hvilleneuve@dimonoff.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=jackzxcui1989@163.com \
    --cc=jirislaby@kernel.org \
    --cc=john.ogness@linutronix.de \
    --cc=jonathanh@nvidia.com \
    --cc=kees@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=m.felsch@pengutronix.de \
    --cc=osama.abdelkader@gmail.com \
    --cc=pmladek@suse.com \
    --cc=sozdayvek@gmail.com \
    --cc=wangfushuai@baidu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.