From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E9577C61DB9 for ; Thu, 27 Aug 2026 10:37:35 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wzXUC-000552-I9; Thu, 27 Aug 2026 06:37:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wzXUA-00054r-S7 for qemu-devel@nongnu.org; Thu, 27 Aug 2026 06:37:30 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wzXU8-0006Sg-1H for qemu-devel@nongnu.org; Thu, 27 Aug 2026 06:37:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787827046; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UZBQHao9PUn8S6/59o5fkSFU8r7colo+TG7baBJuDek=; b=Urg7jRNz6AmCovtb9pYOorjmXwhAXGKM/X15N/DC6gEClux2DZOv0CMcy+eV/BjYjgnsi1 Ebpv9rOmMv+EH5QHK1fn0MO+i+V3mmgg2SmogGyeOHTE1bSmK9cz7Doun91ZoEXopYU/tf 49SF6BVr/tb5HrDd3bfLnmEzEbASbuI= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-528-K8yXyz0zNHSFJw5Fpff-Wg-1; Thu, 27 Aug 2026 06:37:22 -0400 X-MC-Unique: K8yXyz0zNHSFJw5Fpff-Wg-1 X-Mimecast-MFC-AGG-ID: K8yXyz0zNHSFJw5Fpff-Wg_1787827041 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3629B180216B; Thu, 27 Aug 2026 10:37:21 +0000 (UTC) Received: from redhat.com (headnet05.pony-001.prod.iad2.dc.redhat.com [10.2.32.117]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8DC201956044; Thu, 27 Aug 2026 10:37:19 +0000 (UTC) Date: Thu, 27 Aug 2026 11:37:16 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: qemu-devel@nongnu.org, Markus Armbruster , Peter Maydell , Paolo Bonzini Subject: Re: [PATCH] system: improve -mon deprecation warning Message-ID: References: <20260824122942.85863-1-berrange@redhat.com> <95b7d9b3-b61b-448c-9fc3-a3d91d438a1b@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <95b7d9b3-b61b-448c-9fc3-a3d91d438a1b@oss.qualcomm.com> User-Agent: Mutt/2.4.0 (2026-06-19) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Thu, Aug 27, 2026 at 10:56:44AM +0200, Philippe Mathieu-Daudé wrote: > On 24/8/26 14:29, Daniel P. Berrangé wrote: > > Expand the text a bit to make the new syntax more explicit and point > > users to the man page for further info. > > > > Reported-by: Peter Maydell > > Signed-off-by: Daniel P. Berrangé > > --- > > system/vl.c | 7 +++++-- > > 1 file changed, 5 insertions(+), 2 deletions(-) > > > > diff --git a/system/vl.c b/system/vl.c > > index 061cbdf860..d5b5392569 100644 > > --- a/system/vl.c > > +++ b/system/vl.c > > @@ -3239,8 +3239,11 @@ void qemu_init(int argc, char **argv) > > default_monitor = 0; > > break; > > case QEMU_OPTION_mon: > > - warn_report_once("'-mon' is deprecated, use '-object' with " > > - "'monitor-hmp' or 'monitor-qmp' types instead"); > > + warn_report_once("'-mon' is deprecated. Switch to either " > > + "'-object monitor-hmp,id=ID,chardev=CHR-ID' " > > + "or '-object monitor-qmp,id=qmpNN,chardev=CHR-ID' " > > + "instead. See '-object' docs in 'qemu(1)' for further " > > + "configuration guidance."); > > Looking at commit 58b70f21ba6 ("docs: mark '-mon' as deprecated in > favour of -object") I'm not sure this is a good idea to document > '-object monitor-qmp' at all on CLI help. CLI users looking at > help output are likely users of '-mon' for HMP. My 2 cents. The warnings here get reported in machine use of QEMU too, not just interactive usage. In libvirt they'll end up in /var/log/libvirt/qemu/$GUEST.log. I expect most end user non-managed launches of QEMU are using the higher level -monitor for HMP, with -mon more likely machine usage. With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|