Re: [PATCH] system: improve -mon deprecation warning

["Daniel P. Berrangé" <berrange@redhat.com>]

On Thu, Aug 27, 2026 at 09:48:50AM +0100, Peter Maydell wrote:
> On Mon, 24 Aug 2026 at 13:29, Daniel P. Berrangé <berrange@redhat.com> wrote:
> >
> > Expand the text a bit to make the new syntax more explicit and point
> > users to the man page for further info.
> >
> > Reported-by: Peter Maydell <peter.maydell@linaro.org>
> > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> > ---
> >  system/vl.c | 7 +++++--
> >  1 file changed, 5 insertions(+), 2 deletions(-)
> >
> > diff --git a/system/vl.c b/system/vl.c
> > index 061cbdf860..d5b5392569 100644
> > --- a/system/vl.c
> > +++ b/system/vl.c
> > @@ -3239,8 +3239,11 @@ void qemu_init(int argc, char **argv)
> >                  default_monitor = 0;
> >                  break;
> >              case QEMU_OPTION_mon:
> > -                warn_report_once("'-mon' is deprecated, use '-object' with "
> > -                                 "'monitor-hmp' or 'monitor-qmp' types instead");
> > +                warn_report_once("'-mon' is deprecated. Switch to either "
> > +                                 "'-object monitor-hmp,id=ID,chardev=CHR-ID' "
> > +                                 "or '-object monitor-qmp,id=qmpNN,chardev=CHR-ID' "
> 
> why the difference in id=ID vs id=qmpNN ?

A mistake :-)

> > +                                 "instead. See '-object' docs in 'qemu(1)' for further "
> > +                                 "configuration guidance.");
> 
> Personally I think of the HTML docs as our primary documentation
> and the manpages as a kind of "not very well maintained extracted
> subset", so I wouldn't want to point people at qemu(1).

The manpages have full coverage of the CLI args with identical
content as the online manual.

With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|