Re: [PATCH v2 2/2] arm64: dts: freescale: add MR-NAVQ95 basic board support

[Frank Li <Frank.li@oss.nxp.com>]

On Thu, Aug 27, 2026 at 03:15:49PM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
> - [Medium] Missing USB configuration despite commit message claims.
> - [Low] Usage of deprecated 'gpio' property in fixed-regulator
> --
>
> commit 5ca41dda85cf11b2d0c2fcf857ba3ebeca18e3d8
> Author: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
>
> arm64: dts: freescale: add MR-NAVQ95 basic board support
>
> Add basic support for NXP's MR-NAVQ95 board. This includes features like 64GB
> eMMC, up to 16GB LPDDR5, USB and RJ45 ports.
>
> >     * based on i.MX95 19x19 SoC
> >     * 64GB eMMC
> >     * up to 16GB of LPDDR5 memory
> >     * 1 x USB 2.0 TypeC
> >     * 1 x USB 3.0 TypeC
> >     * 1 x RJ45 port with RTL8211 PHY
>
> [Severity: Medium]
> The commit message explicitly lists '1 x USB 2.0 TypeC' and '1 x USB 3.0
> TypeC' as hardware features of the board, but the device tree does not appear
> to enable any USB controllers (like &usb2, &usb3) or define Type-C connectors.
>
> Are these nodes missing from the device tree, or should the commit message be
> updated to reflect the current level of implementation?
>
> > diff --git a/arch/arm64/boot/dts/freescale/imx95-navq.dts b/arch/arm64/boot/dts/freescale/imx95-navq.dts
> > new file mode 100644
> > index 0000000000000..7458e77dc2ae5
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/freescale/imx95-navq.dts
> [ ... ]
> > +	reg_usdhc2_vmmc: regulator-usdhc2 {
> > +		compatible = "regulator-fixed";
> > +		pinctrl-names = "default";
> > +		pinctrl-0 = <&pinctrl_reg_usdhc2_vmmc>;
> > +		regulator-name = "VDD_SD2_3V3";
> > +		regulator-min-microvolt = <3300000>;
> > +		regulator-max-microvolt = <3300000>;
> > +		gpio = <&gpio3 7 GPIO_ACTIVE_HIGH>;
>
> [Severity: Low]
> Could this use the plural "gpios" property instead? While the singular "gpio"
> is still parsed by the gpiolib fallback logic, it is deprecated for new
> devicetree submissions.

Yes, now prefer "s" version. please fix it.

Frank

>
> --
> Sashiko AI review · https://sashiko.dev/#/patchset/20260827150657.1657-1-laurentiumihalcea111@gmail.com?part=2