Re: [PATCH 01/10] dma-buf: Add reference counting to dma_resv

[Andi Shyti <andi.shyti@kernel.org>]

Hi Christian,

> +/**
> + * dma_resv_put - release a reference to a reservation object
> + * @obj: the reservation object
> + *
> + * Decrements the reference count on the dma_resv object. When the reference
> + * count reaches zero, the object is cleaned up with dma_resv_fini() and freed

except that you have removed dma_resv_fini() :-)

Probably you want to say that the object is cleaned up by
dma_resv_release()?

Andi

> + * if it was allocated by dma_resv_alloc().
> + */
> +void dma_resv_put(struct dma_resv *obj)
> +{
> +	if (obj)
> +		kref_put(&obj->refcount, dma_resv_release);
>  }
> -EXPORT_SYMBOL(dma_resv_fini);
> +EXPORT_SYMBOL(dma_resv_put);