From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Felix Fietkau <nbd@nbd.name>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH mt76-fixes] wifi: mt76: mt7925: restore the reset state when fw_pmctrl fails
Date: Fri, 28 Aug 2026 08:56:34 +0200 [thread overview]
Message-ID: <apExIpa_MwXdqHB8@lore-desk> (raw)
In-Reply-To: <20260827162115.1449757-1-nbd@nbd.name>
[-- Attachment #1: Type: text/plain, Size: 1202 bytes --]
> mt7925e_mac_reset() returns directly when mt792xe_mcu_fw_pmctrl()
> fails, leaving MT76_RESET set and the TX worker parked. Every other
> error path jumps to out, which clears both. mt7925_mac_reset_work()
> clears neither, so once every reset attempt fails there, TX stays
> blocked until another reset succeeds.
>
> Jump to out instead.
>
> Fixes: c948b5da6bbe ("wifi: mt76: mt7925: add Mediatek Wi-Fi7 driver for mt7925 chips")
> Signed-off-by: Felix Fietkau <nbd@nbd.name>
Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>
> ---
> drivers/net/wireless/mediatek/mt76/mt7925/pci_mac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7925/pci_mac.c b/drivers/net/wireless/mediatek/mt76/mt7925/pci_mac.c
> index 280797fa0d85..67eb86746779 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7925/pci_mac.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7925/pci_mac.c
> @@ -127,7 +127,7 @@ int mt7925e_mac_reset(struct mt792x_dev *dev)
>
> err = mt792xe_mcu_fw_pmctrl(dev);
> if (err)
> - return err;
> + goto out;
>
> err = __mt792xe_mcu_drv_pmctrl(dev);
> if (err)
> --
> 2.47.3
>
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2026-08-28 6:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-27 16:21 [PATCH mt76-fixes] wifi: mt76: mt7925: restore the reset state when fw_pmctrl fails Felix Fietkau
2026-08-28 6:56 ` Lorenzo Bianconi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=apExIpa_MwXdqHB8@lore-desk \
--to=lorenzo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.