From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 98FAB3DDB1E for ; Fri, 28 Aug 2026 08:10:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787904603; cv=none; b=n9g0ukNJmFolNh+Y0yyLA5o6elKkLdAdvfG3JM5BcEXyfE8jPW1JsoyjhUrBwDvsjDYQDdBNVkhjZ7DPVB4b/xO4rpw20NDk/KKXQURAqWn936oWTcahqJqhGi3oekrrxywfyHNZJ8nHGcNcbvpDyWyuApgMEEQPt9tMgJRebrA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787904603; c=relaxed/simple; bh=DND+91VHQLMiEM6W4UJu0eazGvSo0yONZJ99Z8jWWOk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sSQikhHI//en9zvFe74dAPwfYo0kR5bCkGmvxt8t+2oAVvQZZaC3uxMamUjSagEvx4LIW8xRtSw+rbqNXg5cNGkLiMesV7WzQCbv+VHiscQ/6YE/koj1TuuThzD56xz9cT6OWkrqSpYgZ5hJoM3OIOzEfmrdwPmcdKHKbD7rI+I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HWACTWoh; arc=none smtp.client-ip=209.85.215.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HWACTWoh" Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-cc1c3d79b9bso713619a12.3 for ; Fri, 28 Aug 2026 01:10:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787904602; x=1788509402; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=GLrPdvAk+KW5PmpXBldOm5fk9R4JndtH1s4AmbnDxdc=; b=HWACTWoh0jBxtzKHPKIfOlfqupNww4r5Wtn+fRigPuTGYr7AYoYGyEVObYJsTIQL20 h6w4NFP5MUdMStZA1SdGzJvSvvdzmUETFuaSr7NniIPSwPs4FlTIIV+jV/Ozek67Bk1V e6pkq2XdeHX8x02h35UxcO4rajptbCAFPzfCezGfOMdU28k35y8LeNWkZTzLkNq39o5t m4N2oIAQeJ5ihuzboxdvVoc2ATDhYmFOqJk4C3Lgfj4rnao9gYtKViluP97KZVQF0yeK CTot5DgWxIepc4TwtGHEU1BU9JNT17DGZHM78G4PQmV/TzxJ6vRnxtuuMiCFfvb6cEEq i4iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787904602; x=1788509402; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=GLrPdvAk+KW5PmpXBldOm5fk9R4JndtH1s4AmbnDxdc=; b=E06ucOOqU0lVAHj8OYljCOyQsPTNcQfJXar+al6MBiO2m9eFawqdIogmvaJXjfl2xZ aNHoFlBNVAy3I8hOH5Na9bYAXbxmFtMQZ+1o2pxjFmoUSt5OoaKOl9J1c3XX0zeIjdKL XwNvJ3ZPlM9NQj+BrcV0LvYqoJjHG1h94ZUQ+JYBlPrdlkNtgX2zYSAas0hQTKxa/sjx +Il/G4JwpFrw8Ty22wlJoTjAIq7PvZzCsCpP9yjUK0uEywLPcKoqhqez1fl7yLItEIqB xgMbL6F+/MQdNBQnEDfWjUy48ms9+XVhVwCQKmmBbx40y1r0baD5/m/ZsPIpM5QZEBLm V37w== X-Forwarded-Encrypted: i=1; AHgh+RrEchIY7yUF9szOgXx3n70O9Xi2sXX3Yj/tODJCL6UB0or6bxx1jdFEyqb4QE2XuLvVxtLNJdPxuw4=@vger.kernel.org X-Gm-Message-State: AFuF++nEvflCPSnW1jwpge9W6eww469nAnZ4TSP4EKcp9SEQD6khjaqK TJuEasU/wISdDrTBAuLfD53KAWrTZ7zfbPJznXicjUGNd0Y1Jw+pOu7H X-Gm-Gg: AR+sD12k6koa0VnJsY/iG2zB8lgvbVfBpP8nYbpoM7qVU93BDENoplZFk80DOWuy50R qswdKhaXAs/20nP3T+IkgqGzi+I8IwbMBmJWAfoPHL+LldgBM6fKRWMo2V9c1iPTwzcC2xGREMQ w6n30UmKeTx/3exnW2aZ7pksGT/XVP0EAlsCG4/QwqgXBPnTuk9x2a2f3v+a1CIhKRW0Q9K4O1t jJ+2SMEOk+82aegSxFhgKPgxRGiZCBCmRfoDTsQRuzXd/WUtRCXHno+u0gZsgNHhT2ctdgYaOnn ZGYRC8rWSw/rqcrssTQjxRe+mtyUE5J5vy4Awc4/lgPFyd4bK1YuMGNFEht/sCwq5E8vzP2ZLzC vz3EzYHELpuBOgJmvZVcWl2TmAQ3PUn277iGcdDRkgNRFp8gWEWAEKLFK5ak1TeSLT+4s6lL2Sf G0YSHP+wu3aV4lH683U7NxDh5qIy7tE7E55NpJvANy6j6BKIaLgz6xVItOgo1IZLrn8xBjlV4QC vvABNCK//eHkH5ool7Rcw== X-Received: by 2002:a17:90b:6c5:b0:38e:bbf1:de3f with SMTP id 98e67ed59e1d1-396d0f9d0famr10886672a91.12.1787904600682; Fri, 28 Aug 2026 01:10:00 -0700 (PDT) Received: from localhost (115-70-157-242.ip4.superloop.au. [115.70.157.242]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3286f95a847sm2885093eec.17.2026.08.28.01.09.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Aug 2026 01:10:00 -0700 (PDT) Date: Fri, 28 Aug 2026 18:09:53 +1000 From: Tsz Shan Chan To: Andy Shevchenko Cc: Jonathan Cameron , David Lechner , Nuno =?utf-8?B?U8Oh?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Tsz Shan Chan Subject: Re: [PATCH v2 2/2] iio: light: vcnl4000: add shared IRQ support Message-ID: References: <20260814-vcnl4000-v2-0-9b771290cc1d@jacques.com.au> <20260814-vcnl4000-v2-2-9b771290cc1d@jacques.com.au> <20260822032550.31a0fa9e@jic23-huawei> Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Aug 25, 2026 at 11:48:55AM +0300, Andy Shevchenko wrote: > On Tue, Aug 25, 2026 at 01:22:13PM +1000, Tsz Shan Chan wrote: > > On Mon, Aug 24, 2026 at 11:24:26AM +0300, Andy Shevchenko wrote: > > > On Sat, Aug 22, 2026 at 03:25:50AM +0100, Jonathan Cameron wrote: > > > > On Fri, 14 Aug 2026 14:30:43 +1000 > > > > Tsz Shan Chan wrote: > > > > > > > > The INT output of vcnl4010/4020 and vcnl4040/4200 is open drain active > > > > > low which can be shared with other devices. > > > > > Add IRQF_SHARED and switch the trigger type from IRQF_TRIGGER_FALLING to > > > > > IRQF_TRIGGER_LOW. Edge triggering can miss interrupts on a shared line. > > > > Fairly low risk change but I guess we'll see. > > > > > > > > It used to be annoyingly common for interrupt controllers to support > > > > only edge based interrupts, but hopefully that silliness is a thing > > > > of the past. > > > > > > > > So crossed fingers, I'll apply this and see if we get anyone shouting. > > > > I think we'll get away with it > > > > > > In another thread somebody mentioned a type of the signal that HW generates. > > > Having OD output doesn't prevent HW to behave like it does edge interrupts, > > > id est generating a pulse instead of keeping the level until it gets acked. > > > With that being said, I would ask the datasheet citation to clarify the case. > > > > > > > vcnl4010/4020 datasheet, Page 11 Table 15 Notes: > > "Once an interrupt is generated the corresponding status bit goes to 1 > > and stays there unless it is cleared by writing a 1 in the > > corresponding bit. The int pad will be pulled down while at least one > > of the status bit is 1." > > > > vcnl4040/4200 datasheet, Page 13 Section Interrupt Flag: > > "INT_Flag represents all of the interrupt trigger statuses for ALS and > > PS. If any of these flags trigger from "0" to "1", the INT pin will be > > pulled low. Once the host reads INT_Flag register, all the flags are > > cleared (reset to "0"), and the INT pin is reset to high." > > > > The interrupt is latched. The line stays low until the driver clears it. > > Please, add the summary of these to the commit message. > > -- > With Best Regards, > Andy Shevchenko > > Will update the commit message in v3.