From: Breno Leitao <leitao@debian.org>
To: Guillaume Morin <guillaume@morinfr.org>
Cc: linux-mm@kvack.org, rppt@kernel.org
Subject: Re: [PATCH] selftests/mm: hugetlb_madv_vs_map: add underflow test
Date: Fri, 28 Aug 2026 04:38:27 -0700 [thread overview]
Message-ID: <apFy8_4AnXJcfaHc@gmail.com> (raw)
In-Reply-To: <apB7UWfLAzCvSCss@bender.morinfr.org>
On Thu, Aug 27, 2026 at 08:00:49PM +0200, Guillaume Morin wrote:
> @@ -120,5 +127,80 @@ int main(void)
> }
>
> ksft_test_result_pass("No unexpected huge page allocations\n");
> + huge_ptr = mmap(NULL, mmap_size, PROT_READ | PROT_WRITE,
> + MAP_PRIVATE | MAP_ANONYMOUS | MAP_HUGETLB, -1, 0);
> +
> + if ((unsigned long)huge_ptr == -1)
> + ksft_exit_fail_msg("Failed to allocate huge page\n");
> +
> + {
> + pid_t pid;
> + int pipe_fds[2];
> + unsigned long nr_reserved = 0;
Why do you want to start a C block "{" here? That looks like a bit
weird.
Also, please factor our this new code.
Thanks for the new test,
--breno
prev parent reply other threads:[~2026-08-28 11:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-27 18:00 [PATCH] selftests/mm: hugetlb_madv_vs_map: add underflow test Guillaume Morin
2026-08-28 11:38 ` Breno Leitao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=apFy8_4AnXJcfaHc@gmail.com \
--to=leitao@debian.org \
--cc=guillaume@morinfr.org \
--cc=linux-mm@kvack.org \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.