All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alvin Šipraga" <alvin.sipraga@analog.com>
To: Rahul Sharma <r-sharma3@ti.com>
Cc: peda@lysator.liu.se, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, vigneshr@ti.com
Subject: Re: [PATCH 1/2] dt-bindings: mux-controller: ti: add binding for event mux router
Date: Fri, 28 Aug 2026 13:50:29 +0200	[thread overview]
Message-ID: <apFyu65OOQF1XF2o@analog.com> (raw)
In-Reply-To: <20260828100615.1700223-2-r-sharma3@ti.com>

Hi Rahul,

On Fri, Aug 28, 2026 at 03:36:14PM +0530, Rahul Sharma wrote:
> Add binding for the event mux router of TI's K3 based SoC AM62L.

[...]

> +  ti,reg-mask-val:
> +    $ref: /schemas/types.yaml#/definitions/uint32-matrix
> +    items:
> +      items:
> +        - description: Register offset (relative to reg base)
> +        - description: Bit mask for the mux control bits
> +        - description: Value to write when mux is active (state 1)
> +    minItems: 1
> +    description: |
> +      Array of triplets specifying register offset, mask, and value for each
> +      mux control. Each triplet contains:
> +      - register offset (relative to reg base)
> +      - bit mask for the mux control bits
> +      - value to write when mux is active (state 1)

As I understand it, you are creating a binary (0=off / 1=on) mux control
for each reg-mask-val triplet. But couldn't you just use the mmio-mux
binding/driver for this, delegating the value setting to the consumer?

[...]

> +examples:
> +  - |
> +    #include <dt-bindings/mux/mux.h>
> +
> +    // Example 1: TI AM62L GPIO Mux Router
> +    mux-controller@a00000 {
> +        compatible = "ti,am62l-event-mux-router";
> +        reg = <0xa00000 0x400>;
> +        #mux-control-cells = <1>;
> +
> +        /* Mux Register addresses: 0xa00004 + (J × 4) */
> +        /* GPIO0_40 -> BCDMA trigger 15 */
> +        ti,reg-mask-val = <0x40 0x000ff 0x00028>;
> +        idle-states = <0>;
> +    };

Alternatively,

 foo_mux: mux-controller {
   compatible = "mmio-mux";
   reg = <...>;
   #mux-control-cells = <1>;
   mux-reg-masks = <0x40 0x000ff>;
   idle-states = <0>;
 };

 toto-consumer {
   compatible = "toto";
   mux-states = <&foo_mux 0 0x00028>;
   mux-state-names = "gpio-trigger";
 };

What's wrong with that?

Kind regards,
Alvin

  parent reply	other threads:[~2026-08-28 11:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-28 10:06 [PATCH 0/2] Add TI's event mux router driver and build Rahul Sharma
2026-08-28 10:06 ` [PATCH 1/2] dt-bindings: mux-controller: ti: add binding for event mux router Rahul Sharma
2026-08-28 10:13   ` sashiko-bot
2026-08-28 11:50   ` Alvin Šipraga [this message]
2026-09-02 12:25     ` [EXTERNAL] " rahul sharma
2026-08-28 16:27   ` Conor Dooley
2026-08-28 10:06 ` [PATCH 2/2] mux-controller: ti: add driver " Rahul Sharma
2026-08-28 10:20   ` sashiko-bot
2026-08-29 15:14   ` Peter Rosin
2026-09-03 19:16     ` [EXTERNAL] " Sharma, Rahul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=apFyu65OOQF1XF2o@analog.com \
    --to=alvin.sipraga@analog.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peda@lysator.liu.se \
    --cc=r-sharma3@ti.com \
    --cc=robh@kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.