From: "Dr. David Alan Gilbert" <dave@treblig.org>
To: "Philippe Mathieu-Daudé" <philmd@oss.qualcomm.com>
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
qemu-devel@nongnu.org,
"Philippe Mathieu-Daudé" <philmd@mailo.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Thomas Huth" <th.huth+qemu@posteo.eu>,
"Denis V. Lunev" <den@openvz.org>,
"Jason J. Herne" <jjherne@linux.ibm.com>,
"Brian Cain" <brian.cain@oss.qualcomm.com>
Subject: Re: [PATCH v5 00/50] Make HMP optional (and later standalone)
Date: Fri, 28 Aug 2026 18:01:42 +0000 [thread overview]
Message-ID: <apHNBpl68IcHvlD6@gallifrey> (raw)
In-Reply-To: <e55988ca-43d0-41ec-8a3b-d839e8138461@oss.qualcomm.com>
* Philippe Mathieu-Daudé (philmd@oss.qualcomm.com) wrote:
> On 28/8/26 14:03, Marc-André Lureau wrote:
> > Hi,
> >
> > This series makes HMP compile-time optional via --disable-hmp. The
> > resulting binary speaks only QMP - reducing the attack surface, binary
> > size and enforcing a separation between machine-readable interface and
> > interactive debugging console.
> >
> > QMP offers almost all the functionality HMP could provide, so a separate
> > standalone "HMP-like" console could be implemented on top of it. The
> > rough list of missing commands (+complexity estimation) after this
> > series:
>
>
> > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> > ---
> > Changes in v5:
> > - renamed local variable hmp_mon -> hmp in patch for consistency
> > - renamed error_vprintf_mon/error_printf_mon -> error_vprintf_hmp/error_printf_hmp
> > - simplified default_monitor init with IS_ENABLED(CONFIG_HMP)
> > - added early NULL return in qemu_vprintf/qemu_vfprintf
> > - reworked !opts->has_mode path to use explicit error_setg() when HMP is disabled
> > - split device-introspect-test patch
> > - rebased, collected tags, all reviewed, ready-to-merge
>
> Thanks for the final polishing. Everything LGTM!
Yeh better merge it before anything moves!
(Assume Marc-André is sending the pull).
Dave
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
next prev parent reply other threads:[~2026-08-28 18:02 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-28 12:03 [PATCH v5 00/50] Make HMP optional (and later standalone) Marc-André Lureau
2026-08-28 12:03 ` [PATCH v5 01/50] build-sys: introduce CONFIG_HMP Marc-André Lureau
2026-08-28 12:03 ` [PATCH v5 02/50] vl: fix -monitor none prefix matching Marc-André Lureau
2026-08-28 12:04 ` [PATCH v5 03/50] hmp: remove 'vcpu' argument from trace-event help Marc-André Lureau
2026-08-28 12:04 ` [PATCH v5 04/50] hmp: fix snapshot_blkdev argument type Marc-André Lureau
2026-08-28 12:04 ` [PATCH v5 05/50] target/i386: decouple cpu_x86_inject_mce() from Monitor Marc-André Lureau
2026-08-28 12:04 ` [PATCH v5 06/50] target/i386: return an error for invalid CPU in hmp_mce() Marc-André Lureau
2026-08-28 12:04 ` [PATCH v5 07/50] system: move gpa2hva() to system memory unit Marc-André Lureau
2026-08-28 12:04 ` [PATCH v5 08/50] monitor: move HMP-only fields from Monitor to MonitorHMP Marc-André Lureau
2026-08-28 12:04 ` [PATCH v5 09/50] tests/functional: use query-version QMP command instead of HMP Marc-André Lureau
2026-08-28 12:04 ` [PATCH v5 10/50] net/qapi: add x-query-usernet command Marc-André Lureau
2026-08-28 12:04 ` [PATCH v5 11/50] python, tests: switch usernet queries from HMP to QMP Marc-André Lureau
2026-08-28 12:04 ` [PATCH v5 12/50] tests/qtest/pnv: drop unnecessary -serial mon:stdio Marc-André Lureau
2026-08-28 12:04 ` [PATCH v5 13/50] tests/qtest/qmp-test: don't depend on human-monitor-command Marc-André Lureau
2026-08-28 12:04 ` [PATCH v5 14/50] tests/qtest/numa-test: replace HMP "info numa" with QMP query-cpus-fast Marc-André Lureau
2026-08-28 12:04 ` [PATCH v5 15/50] tests/qtest/cdrom-test: replace HMP "info block" with QMP query-block Marc-André Lureau
2026-08-28 12:04 ` [PATCH v5 16/50] tests/qtest/device-introspect-test: replace 'info qom-tree' Marc-André Lureau
2026-08-28 12:04 ` [PATCH v5 17/50] tests/qtest/device-introspect-test: restrict test when !CONFIG_HMP Marc-André Lureau
2026-08-28 12:04 ` [PATCH v5 18/50] tests/qemu-iotests/205: fix race in assertExportNotFound Marc-André Lureau
2026-08-28 12:04 ` [PATCH v5 19/50] net: add x-query-network QMP command Marc-André Lureau
2026-08-28 12:04 ` [PATCH v5 20/50] tests/qtest/netdev-socket: replace HMP with x-query-network QMP Marc-André Lureau
2026-08-28 12:04 ` [PATCH v5 21/50] qemu-io: propagate errors through Error API instead of printf Marc-André Lureau
2026-08-28 12:04 ` [PATCH v5 22/50] block: add x-qemu-io QMP command Marc-André Lureau
2026-08-28 12:04 ` [PATCH v5 23/50] qtest: add qemu-io command to the qtest protocol Marc-André Lureau
2026-08-28 12:04 ` [PATCH v5 24/50] qtest/ide-test: convert to use qtest qemu-io command Marc-André Lureau
2026-08-28 12:04 ` [PATCH v5 25/50] tests/qemu-iotests: add qmp_qemu_io() Marc-André Lureau
2026-08-28 12:04 ` [PATCH v5 26/50] tests/qemu-iotests: convert pause/resume_drive() to QMP Marc-André Lureau
2026-08-28 12:04 ` [PATCH v5 27/50] monitor: reject readline monitor when HMP is disabled Marc-André Lureau
2026-08-28 12:04 ` [PATCH v5 28/50] system: guard HMP initialization paths with CONFIG_HMP Marc-André Lureau
2026-08-28 12:04 ` [PATCH v5 29/50] tests: skip HMP-dependent tests when HMP is disabled Marc-André Lureau
2026-08-28 12:04 ` [PATCH v5 30/50] monitor: isolate HMP declarations in hmp.h Marc-André Lureau
2026-08-28 12:04 ` [PATCH v5 31/50] monitor: change HMPCommand cmd to take MonitorHMP Marc-André Lureau
2026-08-28 12:04 ` [PATCH v5 32/50] monitor: make hmp_handle_error() " Marc-André Lureau
2026-08-28 12:04 ` [PATCH v5 33/50] monitor: add monitor_cur_hmp() helper Marc-André Lureau
2026-08-28 12:04 ` [PATCH v5 34/50] qemu-print: document HMP/QMP behaviour better Marc-André Lureau
2026-08-28 12:04 ` [PATCH v5 35/50] error-report: switch to use monitor_cur_hmp() Marc-André Lureau
2026-08-28 12:04 ` [PATCH v5 36/50] monitor: tighten monitor_set_cpu()/get_cpu() Marc-André Lureau
2026-08-28 12:04 ` [PATCH v5 37/50] monitor: tighten monitor_printf*() Marc-André Lureau
2026-08-28 12:04 ` [PATCH v5 38/50] hexagon: make dump_mmu() take MonitorHMP Marc-André Lureau
2026-08-28 12:04 ` [PATCH v5 39/50] qdev-monitor: make print_dev() callback " Marc-André Lureau
2026-08-28 12:04 ` [PATCH v5 40/50] qapi: make HMP-specific schema entries conditional on CONFIG_HMP Marc-André Lureau
2026-08-28 12:04 ` [PATCH v5 41/50] Guard HMP command implementations with CONFIG_HMP Marc-André Lureau
2026-08-28 12:04 ` [PATCH v5 42/50] target: guard MonitorDef tables " Marc-André Lureau
2026-08-28 12:04 ` [PATCH v5 43/50] hw: guard BusClass::print_dev " Marc-André Lureau
2026-08-28 12:04 ` [PATCH v5 44/50] hexagon: condition HMP-specific code Marc-André Lureau
2026-08-28 12:04 ` [PATCH v5 45/50] build-sys: make HMP source files conditional on have_hmp Marc-André Lureau
2026-08-28 12:04 ` [PATCH v5 46/50] stubs: split monitor-core stubs into separate compilation units Marc-André Lureau
2026-08-28 12:04 ` [PATCH v5 47/50] monitor: move monitor_hmp_print*() functions to hmp.c Marc-André Lureau
2026-08-28 12:04 ` [PATCH v5 48/50] monitor: move HMP-specific to monitor-hmp-internal.h Marc-André Lureau
2026-08-28 12:04 ` [PATCH v5 49/50] build-sys: add 'hmp' option Marc-André Lureau
2026-08-28 12:04 ` [PATCH v5 50/50] gitlab: --disable-hmp in build-without-defaults Marc-André Lureau
2026-08-28 16:52 ` [PATCH v5 00/50] Make HMP optional (and later standalone) Philippe Mathieu-Daudé
2026-08-28 18:01 ` Dr. David Alan Gilbert [this message]
2026-08-31 8:48 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=apHNBpl68IcHvlD6@gallifrey \
--to=dave@treblig.org \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=brian.cain@oss.qualcomm.com \
--cc=den@openvz.org \
--cc=jjherne@linux.ibm.com \
--cc=marcandre.lureau@redhat.com \
--cc=philmd@mailo.com \
--cc=philmd@oss.qualcomm.com \
--cc=qemu-devel@nongnu.org \
--cc=th.huth+qemu@posteo.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.