Re: [PATCH 1/2] test: Skip tst.aggmod_full2.sh

[Kris Van Hees <kris.van.hees@oracle.com>]

On Wed, Mar 18, 2026 at 05:48:25PM -0400, eugene.loh@oracle.com wrote:
> From: Eugene Loh <eugene.loh@oracle.com>
> 
> The test was only being run on older x86 systems, where it had been
> failing consistently for a long time.  Since kernels are moving from
> kallmodsyms to modules.builtin.ranges, we do not care much about such
> problems.
> 
> Signed-off-by: Eugene Loh <eugene.loh@oracle.com>

Reviewed-by: Kris Van Hees <kris.van.hees@oracle.com>

> ---
>  test/unittest/aggs/tst.aggmod_full2.x | 17 ++++++++++++++++-
>  1 file changed, 16 insertions(+), 1 deletion(-)
> 
> diff --git a/test/unittest/aggs/tst.aggmod_full2.x b/test/unittest/aggs/tst.aggmod_full2.x
> index 3660504ad..a530a3d2d 100755
> --- a/test/unittest/aggs/tst.aggmod_full2.x
> +++ b/test/unittest/aggs/tst.aggmod_full2.x
> @@ -1,10 +1,25 @@
>  #!/bin/bash
>  #
>  # Oracle Linux DTrace.
> -# Copyright (c) 2018, 2024, Oracle and/or its affiliates. All rights reserved.
> +# Copyright (c) 2018, 2026, Oracle and/or its affiliates. All rights reserved.
>  # Licensed under the Universal Permissive License v 1.0 as shown at
>  # http://oss.oracle.com/licenses/upl.
>  
> +# Let us skip this test altogether:
> +#   * The test was never vetted on arm.
> +#   * The test does not run on newer kernels since they have no kallmodsyms.
> +#   * On older x86 platforms, the test has failed consistently for a long time.
> +# The test had been intended for checking /proc/kallmodsyms,
> +# but we are migrating to a modules.builtin.ranges approach.
> +# When we are absolutely sure we do not care about this test, it can be removed.
> +
> +echo "test is deprecated"
> +exit 2
> +
> +###############################################
> +### The older contents of this file follow. ###
> +###############################################
> +
>  # The test still needs to be vetted on ARM64, including for copyinstr() support.
>  # Once it runs on ARM64, the slower tst.aggmod_full.sh test can be removed.
>  
> -- 
> 2.47.3
>