From: Matthew Wilcox <willy@infradead.org>
To: sashiko-reviews@lists.linux.dev
Cc: Jeff Layton <jlayton@kernel.org>,
Anna Schumaker <anna@kernel.org>,
tytso@mit.edu, Chuck Lever <cel@kernel.org>,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH 9/9] filemap: Remove FGP_NOFS
Date: Sun, 30 Aug 2026 05:32:15 +0100 [thread overview]
Message-ID: <apOyT6uKUPY5P_JR@casper.infradead.org> (raw)
In-Reply-To: <20260830042742.84E321F000E9@smtp.kernel.org>
On Sun, Aug 30, 2026 at 04:27:42AM +0000, sashiko-bot@kernel.org wrote:
> [Severity: Low]
> Does this removal break the build for f2fs?
>
> Looking at f2fs_write_begin() in fs/f2fs/data.c, it still relies on the
> removed FGP_NOFS flag:
>
> folio = f2fs_filemap_get_folio(mapping, index,
> FGP_LOCK | FGP_WRITE | FGP_CREAT | FGP_NOFS,
> mapping_gfp_mask(mapping));
Hi Sashiko, the tree you've applied this to for analysis doesn't include
commit 35e5554ec14b which removes this flag. That commit was merged
into Linus' tree in 115bd364ab20, please update your tree.
next prev parent reply other threads:[~2026-08-30 4:32 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-30 4:18 [PATCH 0/9] Remove FGP_NOFS Matthew Wilcox (Oracle)
2026-08-30 4:18 ` [PATCH 1/9] mm: Improve memalloc_nofs_save() documentation Matthew Wilcox (Oracle)
2026-08-30 4:21 ` sashiko-bot
2026-08-31 9:59 ` Jan Kara
2026-08-30 4:18 ` [PATCH 2/9] ext4: Remove uses of FGP_NOFS Matthew Wilcox (Oracle)
2026-08-30 4:27 ` sashiko-bot
2026-08-31 10:03 ` Jan Kara
2026-08-31 12:32 ` Baokun Li
2026-09-01 2:17 ` Zhang Yi
2026-09-03 14:44 ` Theodore Tso
2026-08-30 4:18 ` [PATCH 3/9] erofs: Remove redundant FGP_NOFS Matthew Wilcox (Oracle)
2026-08-30 4:24 ` sashiko-bot
2026-08-31 10:08 ` Jan Kara
2026-09-01 5:55 ` Gao Xiang
2026-08-30 4:18 ` [PATCH 4/9] nfs: " Matthew Wilcox (Oracle)
2026-08-30 4:26 ` sashiko-bot
2026-08-31 10:07 ` Jan Kara
2026-08-30 4:18 ` [PATCH 5/9] ntfs: Remove FGP_NOFS from __ntfs_inode_resident_attr_pwrite() Matthew Wilcox (Oracle)
2026-08-30 4:39 ` sashiko-bot
2026-08-31 23:34 ` Namjae Jeon
2026-08-30 4:18 ` [PATCH 6/9] ntfs: Remove redundant FGP_NOFS from ntfs_wof_collect_dest() Matthew Wilcox (Oracle)
2026-08-30 4:25 ` sashiko-bot
2026-08-31 23:31 ` Namjae Jeon
2026-08-30 4:18 ` [PATCH 7/9] squashfs: Remove use of FGP_NOFS Matthew Wilcox (Oracle)
2026-08-30 4:33 ` sashiko-bot
2026-08-31 10:11 ` Jan Kara
2026-08-30 4:18 ` [PATCH 8/9] filemap: Remove redundant FGP_NOFS Matthew Wilcox (Oracle)
2026-08-30 4:25 ` sashiko-bot
2026-08-31 10:06 ` Jan Kara
2026-08-30 4:18 ` [PATCH 9/9] filemap: Remove FGP_NOFS Matthew Wilcox (Oracle)
2026-08-30 4:27 ` sashiko-bot
2026-08-30 4:32 ` Matthew Wilcox [this message]
2026-08-31 10:07 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=apOyT6uKUPY5P_JR@casper.infradead.org \
--to=willy@infradead.org \
--cc=anna@kernel.org \
--cc=cel@kernel.org \
--cc=jlayton@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.