From: Hangbin Liu <hangbin.liu@linux.dev>
To: Nikolay Aleksandrov <razor@blackwall.org>
Cc: David Laight <david.laight.linux@gmail.com>,
Jay Vosburgh <jv@jvosburgh.net>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Hangbin Liu <liuhangbin@kylinos.cn>
Subject: Re: [PATCH net v5 2/2] bonding: fix u32 overflow in compute_gap()
Date: Mon, 31 Aug 2026 09:23:31 +0800 [thread overview]
Message-ID: <apTXkxseTr_1to2u@fedora> (raw)
In-Reply-To: <31228099-41a8-4976-acc3-9b320a5012ea@blackwall.org>
On Fri, Aug 28, 2026 at 12:19:47PM +0300, Nikolay Aleksandrov wrote:
> > > How is that relevant to these patches?
> > > And how does that help at all if today that is done at about 10 second interval?
> >
> > The 10 seconds is almost certainly completely arbitrary.
> > It is relevant because the 64bit divide is significantly expensive on 32bit.
> >
> > David
> >
>
> Yeah, that is clear. But currently that recalculation is done once every 10
> seconds, such optimizations will be noise. Regardless of that, these changes
> are unrelated to the problem he is fixing with the set.
+1.
Thanks
Hangbin
prev parent reply other threads:[~2026-08-31 1:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-25 1:01 [PATCH net v5 0/2] bonding: fix TLB load-tracking overflow on high-speed NICs Hangbin Liu
2026-08-25 1:01 ` [PATCH net v5 1/2] bonding: convert unbalanced_load to per-cpu state Hangbin Liu
2026-08-26 7:34 ` Nikolay Aleksandrov
2026-08-25 1:01 ` [PATCH net v5 2/2] bonding: fix u32 overflow in compute_gap() Hangbin Liu
2026-08-26 7:34 ` Nikolay Aleksandrov
2026-08-27 13:42 ` Paolo Abeni
2026-08-28 1:28 ` Hangbin Liu
2026-08-27 18:20 ` David Laight
2026-08-27 19:09 ` Nikolay Aleksandrov
2026-08-27 20:56 ` David Laight
2026-08-28 9:19 ` Nikolay Aleksandrov
2026-08-31 1:23 ` Hangbin Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=apTXkxseTr_1to2u@fedora \
--to=hangbin.liu@linux.dev \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=david.laight.linux@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jv@jvosburgh.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuhangbin@kylinos.cn \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.