Re: [PATCH v3 3/9] dmaengine: dw-axi-dmac: Use bus width capability helpers

[nuno.sa@analog.com]

On Mon, Aug 31, 2026 at 11:58:19AM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] Mismatch between commit message claims and actual function calls.
> --
> 
> commit d65f8f1318d2325009bb83a6877e70b0e20de0ed
> Author: Nuno Sá <nuno.sa@analog.com>
> 
> dmaengine: dw-axi-dmac: Use bus width capability helpers
> 
> This commit updates the dw-axi-dmac driver to advertise supported bus widths
> using capability helpers instead of assigning legacy u32 masks directly.
> 
> > Advertise the supported bus widths through dma_set_src_bus_widths()
> > and dma_set_dst_bus_widths() instead of assigning the legacy u32 masks
> > directly. This keeps the driver using the new bitmap representation
> > while preserving legacy fields during the transition.
> 
> [Severity: Medium]
> Is this description accurate regarding the functions being used?
> 
> The commit message explicitly states that the patch uses
> dma_set_src_bus_widths() and dma_set_dst_bus_widths(), but the actual
> implementation in dw_probe() uses dma_bus_width_set_many():
> 
> > diff --git a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
> > --- a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
> > +++ b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
> [ ... ]
> > @@ -1565,8 +1566,13 @@ static int dw_probe(struct platform_device *pdev)
> >  
> >  	/* DMA capabilities */
> >  	dw->dma.max_burst = hdata->axi_rw_burst_len;
> > -	dw->dma.src_addr_widths = AXI_DMA_BUSWIDTHS;
> > -	dw->dma.dst_addr_widths = AXI_DMA_BUSWIDTHS;
> > +	ret = dma_bus_width_set_many(dw->dma.src_bus_widths, buswidths, ARRAY_SIZE(buswidths));
> > +	if (ret)
> > +		return ret;
> > +
> > +	ret = dma_bus_width_set_many(dw->dma.dst_bus_widths, buswidths, ARRAY_SIZE(buswidths));
> 
> Could the commit message be updated to match the API that is actually called
> in the driver?

Yes! It should!

> -- 
> Sashiko AI review · https://sashiko.dev/#/patchset/20260831-dmaengine-support-wider-dma-masks-v3-0-507d97496f2d@analog.com?part=3