From: Gabriel Goller <g.goller@proxmox.com>
To: "Asbjørn Sloth Tønnesen" <ast@fiberby.net>
Cc: Donald Hunter <donald.hunter@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Felix Maurer <fmaurer@redhat.com>,
Danielle Ratson <danieller@nvidia.com>,
Fernando Fernandez Mancera <fmancera@suse.de>,
Patrick Rohr <prohr@google.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 3/3] netlink: specs: rt-link: add force-forwarding
Date: Mon, 31 Aug 2026 14:54:25 +0200 [thread overview]
Message-ID: <apV5QD3EefKLmrZZ@luna.proxmox.com> (raw)
In-Reply-To: <20260831093458.472180-4-ast@fiberby.net>
On 31.08.2026 09:34, Asbjørn Sloth Tønnesen wrote:
> Add missing enum member force-forwarding to ipv6-devconf.
>
> In commit f24987ef6959 ("ipv6: add `force_forwarding` sysctl to
> enable per-interface forwarding"), the DEVCONF_* enum was extended
> with DEVCONF_FORCE_FORWARDING, however Gabriel forgot to add it
> to the spec.
>
> This pre-existing issue was detected by Sashiko, when reviewing the
> first patch in this series.
>
> Link: https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260824103816.40040-1-ast%40fiberby.net
> Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.net>
> ---
Ahh, missed this. Thanks for fixing this!
Consider:
Reviewed-by: Gabriel Goller <g.goller@proxmox.com>
> Documentation/netlink/specs/rt-link.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/netlink/specs/rt-link.yaml b/Documentation/netlink/specs/rt-link.yaml
> index ab677801cde8..61ebb9a2bad5 100644
> --- a/Documentation/netlink/specs/rt-link.yaml
> +++ b/Documentation/netlink/specs/rt-link.yaml
> @@ -496,6 +496,8 @@ definitions:
> name: accept-untracked-na
> -
> name: accept-ra-min-lft
> + -
> + name: force-forwarding
> -
> name: ifla-icmp6-stats
> enum-name:
> --
> 2.55.0
next prev parent reply other threads:[~2026-08-31 12:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-31 9:34 [PATCH net-next v2 0/3] netlink: specs: rt-link: ipv6 devconf updates Asbjørn Sloth Tønnesen
2026-08-31 9:34 ` [PATCH net-next v2 1/3] netlink: specs: rt-link: update ipv6 devconf doc Asbjørn Sloth Tønnesen
2026-08-31 9:34 ` [PATCH net-next v2 2/3] netlink: specs: rt-link: add accept-ra-min-lft Asbjørn Sloth Tønnesen
2026-08-31 9:52 ` Fernando Fernandez Mancera
2026-08-31 9:34 ` [PATCH net-next v2 3/3] netlink: specs: rt-link: add force-forwarding Asbjørn Sloth Tønnesen
2026-08-31 9:53 ` Fernando Fernandez Mancera
2026-08-31 12:54 ` Gabriel Goller [this message]
2026-09-01 13:30 ` [PATCH net-next v2 0/3] netlink: specs: rt-link: ipv6 devconf updates patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=apV5QD3EefKLmrZZ@luna.proxmox.com \
--to=g.goller@proxmox.com \
--cc=ast@fiberby.net \
--cc=danieller@nvidia.com \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=fmancera@suse.de \
--cc=fmaurer@redhat.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=prohr@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.