Re: [PATCH 7/7] net/iavf: remove undocumented conditional macros

[Bruce Richardson <bruce.richardson@intel.com>]

On Mon, Aug 31, 2026 at 12:58:32PM +0200, David Marchand wrote:
> On Mon, 31 Aug 2026 at 12:27, Bruce Richardson
> <bruce.richardson@intel.com> wrote:
> >
> > The iavf driver included two #defines which enabled the QinQ and
> > checksum offload in the code. The intent as documented in code comments
> > was that any user not taking advantage of these features could remove
> > the #defines to cut out some code. However, this was never actually
> > publicly documented, and the use of these defines was never tested in
> > any builds, making them fragile - if not already broken. Therefore, just
> > remove these build time macros.
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> 
> Though unrelated to current series, were the AVX512 knobs tested?
> 
> #define IAVF_RX_CSUM_OFFLOAD
> #define IAVF_RX_VLAN_OFFLOAD
> #define IAVF_RX_RSS_OFFLOAD
> #define IAVF_RX_PTYPE_OFFLOAD
> #define IAVF_RX_FDIR_OFFLOAD
> #define IAVF_RX_TS_OFFLOAD
> 
I don't know, I didn't look at those. I came across the other two when
looking at the Tx side (mainly AVX2)

/Bruce