From: Andi Kleen <ak@linux.intel.com>
To: sashiko-reviews@lists.linux.dev
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v5 2/4] perf tools top: Add --weight option
Date: Mon, 31 Aug 2026 10:35:15 -0700 [thread overview]
Message-ID: <apW7Uy6QOvWEGVSE@tassilo> (raw)
In-Reply-To: <20260830194358.0584A1F000E9@smtp.kernel.org>
>
> [Severity: High]
> This is a pre-existing issue, but does this code write out of bounds or
> dereference a NULL pointer?
>
> If reallocarray() fails, tmp is NULL, so minors->minors and minors->minors_len
> are not updated.
OOM checking in user space is generally a folly anyways because if it
ever happens you're already in russian roulette with the OOM killer
killing you.
The right fix would be to use a xreallocarray that exits on error.
But it has nothing to do with these patches.
-Andi
next prev parent reply other threads:[~2026-08-31 17:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-30 19:34 v5 of the perf weight annotation patchkit Andi Kleen
2026-08-30 19:34 ` [PATCH v5 1/4] perf tools record: Modernize -W man page Andi Kleen
2026-08-30 19:37 ` sashiko-bot
2026-08-30 19:34 ` [PATCH v5 2/4] perf tools top: Add --weight option Andi Kleen
2026-08-30 19:43 ` sashiko-bot
2026-08-31 17:35 ` Andi Kleen [this message]
2026-08-30 19:34 ` [PATCH v5 3/4] perf tools: Add support for displaying weights in annotate Andi Kleen
2026-08-30 19:53 ` sashiko-bot
2026-08-30 19:34 ` [PATCH v5 4/4] perf tools: Add test for weight annotation Andi Kleen
2026-08-30 19:56 ` sashiko-bot
2026-08-31 18:32 ` Andi Kleen
2026-09-01 15:14 ` v5 of the perf weight annotation patchkit Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=apW7Uy6QOvWEGVSE@tassilo \
--to=ak@linux.intel.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.