From: Christoph Hellwig <hch@infradead.org>
To: Chris Wedgwood <cw@f00f.org>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/9] libxfs: don't corrupt a delwri list when a buffer is queued twice
Date: Mon, 31 Aug 2026 06:38:03 -0700 [thread overview]
Message-ID: <apWDuwumraY7BV1z@infradead.org> (raw)
In-Reply-To: <2bc415d28f12b661f5286c282cba597a33b9b0e8.1788110147.git.cw@f00f.org>
On Thu, Aug 20, 2026 at 05:26:22PM -0700, Chris Wedgwood wrote:
> The kernel avoids this with the _XBF_DELWRI_Q flag. There is no such
> flag in userspace, but list membership is an accurate substitute here
> because both xfs_buf_delwri_submit() and xfs_buf_delwri_cancel() remove
> entries with list_del_init(), so a buffer that is not on a list always
> has an empty b_list.
We could add the flag and make the code closer to the kernel, though.
Did you consider that, and if so what speaks against it?
next prev parent reply other threads:[~2026-08-31 13:38 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-30 17:15 [PATCH 0/9] xfsprogs: add xfs_repair -R --- log replay Chris Wedgwood
2026-08-21 0:22 ` [PATCH 1/9] libxfs: make XBF_DONE actually mark a buffer uptodate Chris Wedgwood
2026-08-31 13:37 ` Christoph Hellwig
2026-08-21 0:26 ` [PATCH 2/9] libxfs: don't corrupt a delwri list when a buffer is queued twice Chris Wedgwood
2026-08-31 13:38 ` Christoph Hellwig [this message]
2026-08-21 5:42 ` [PATCH 3/9] libxfs: record a failed buffer write when it fails Chris Wedgwood
2026-08-31 13:39 ` Christoph Hellwig
2026-08-27 5:08 ` [PATCH 6/9] libxfs-diff: also compare libxlog against the kernel Chris Wedgwood
2026-08-31 13:40 ` Christoph Hellwig
2026-08-31 17:37 ` Darrick J. Wong
2026-09-02 23:25 ` Dave Chinner
2026-08-27 5:08 ` [PATCH 4/9] libxlog: rename xfs_log_recover.c to logscan.c Chris Wedgwood
2026-08-31 13:42 ` Christoph Hellwig
2026-08-27 5:09 ` [PATCH 5/9] libxlog: import the kernel's log recovery, log items and AIL Chris Wedgwood
2026-08-31 13:45 ` Christoph Hellwig
2026-09-02 23:48 ` Dave Chinner
2026-08-27 5:24 ` [PATCH 7/9] libxlog: build the imported kernel code Chris Wedgwood
2026-08-31 13:46 ` Christoph Hellwig
2026-08-27 5:25 ` [PATCH 8/9] xfs_repair: add -R to replay a dirty log before repairing Chris Wedgwood
2026-08-31 13:48 ` Christoph Hellwig
2026-09-02 23:57 ` Dave Chinner
2026-08-27 5:48 ` [PATCH 9/9] xfs_repair: finish deletions the crash interrupted Chris Wedgwood
2026-08-31 13:50 ` Christoph Hellwig
2026-08-31 13:36 ` [PATCH 0/9] xfsprogs: add xfs_repair -R --- log replay Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=apWDuwumraY7BV1z@infradead.org \
--to=hch@infradead.org \
--cc=cw@f00f.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.