From: Sakari Ailus <sakari.ailus@iki.fi>
To: Hans Verkuil <hverkuil+cisco@kernel.org>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
Lars Ljung <lars@matholka.se>
Subject: Re: [PATCH] media: usb: em28xx: check if vbi is supported before calling, vb2_queue_init
Date: Tue, 8 Sep 2026 15:12:42 +0300 [thread overview]
Message-ID: <ap_7uv05fa4fTk92@valkosipuli.retiisi.eu> (raw)
In-Reply-To: <3e01154b-ab4d-4cb3-90d7-a5dce4e5b2c4@kernel.org>
On Fri, Jul 31, 2026 at 12:36:52PM +0200, Hans Verkuil wrote:
> If the device does not support vbi, then the vbi queue is still
> initialized with vb2_queue_init(), which fails with a WARNing because
> the q->lock pointer is never set.
>
> Only call vb2_queue_init for the vbi queue if vbi is actually
> supported.
>
> Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
> Tested-by: Hans Verkuil <hverkuil+cisco@kernel.org>
> Reported-by: Lars Ljung <lars@matholka.se>
> Closes: https://lore.kernel.org/linux-media/8ede91cc-b505-458a-94ef-fb02270f9701@matholka.se/T/#u
Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
--
Sakari Ailus
prev parent reply other threads:[~2026-09-08 12:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-31 10:36 [PATCH] media: usb: em28xx: check if vbi is supported before calling, vb2_queue_init Hans Verkuil
2026-09-08 12:12 ` Sakari Ailus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ap_7uv05fa4fTk92@valkosipuli.retiisi.eu \
--to=sakari.ailus@iki.fi \
--cc=hverkuil+cisco@kernel.org \
--cc=lars@matholka.se \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.