From: Carlo Caione <ccaione@baylibre.com>
To: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Cc: u-boot@lists.u-boot-project.org,
Ahmad Fatoum <a.fatoum@barebox.org>,
David Lechner <dlechner@baylibre.com>,
Julien Masson <jmasson@baylibre.com>,
Vitor Sato Eschholz <vsatoes@baylibre.com>,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
Tom Rini <trini@konsulko.com>, Simon Glass <sjg@chromium.org>,
Quentin Schulz <quentin.schulz@cherry.de>,
Marek Vasut <marek.vasut+renesas@mailbox.org>,
Johan Jonker <jbx6244@gmail.com>,
Jonas Karlman <jonas@kwiboo.se>, Randolph Sapp <rs@ti.com>,
Daniel Golle <daniel@makrotopia.org>,
James Hilliard <james.hilliard1@gmail.com>,
Aristo Chen <aristo.chen@canonical.com>,
Peng Fan <peng.fan@nxp.com>, Vincent Jardin <vjardin@free.fr>,
Peter Robinson <pbrobinson@gmail.com>
Subject: Re: [PATCH v3 4/5] efi_loader: bootmgr: install the firmware-owned devicetree
Date: Tue, 8 Sep 2026 12:05:48 +0200 [thread overview]
Message-ID: <ap_dvWDuPmSNKD4g@macbook> (raw)
In-Reply-To: <CAC_iWj+hcckuyaMGmEJgNkEow6S4Uv5eqq3YTUtkKQcM6U5Prw@mail.gmail.com>
On Tue, Sep 08, 2026 at 12:50:33 +0100, Ilias Apalodimas wrote:
> Hi Carlo,
Hello,
[...]
> > > Any reason we are doing the _hex variant instead of env_get? Don't we
> > want
> > > to bail out if the env variable isnt defined instead of picking 0x0 ?
> >
> > We do, but we do that in firmware_fdt_stage() that is returning -EINVAL
> > before loading or copying the FIT (so we return EFI_DEVICE_ERROR from
> > this function in the end).
> >
>
> That might end up being problematic. I don't know if any devices do that
> today but 0x0 is a valid address.
> Can't we get rid of the check in firmware_fdt_stage() and never call it if
> we don't have an address set?
Ouch, yes, you are right. I guess I'll fix this in V4 then. Thanks for
reviewing this and spotting the problem.
Cheers,
--
Carlo Caione
next prev parent reply other threads:[~2026-09-08 10:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-03 13:09 [PATCH v3 0/5] firmware-owned devicetree for EBBR / SystemReady DeviceTree Carlo Caione
2026-09-03 13:09 ` [PATCH v3 1/5] efi_loader: bootmgr: preserve a passed devicetree Carlo Caione
2026-09-03 13:09 ` [PATCH v3 2/5] boot: add a firmware-owned devicetree source Carlo Caione
2026-09-03 13:09 ` [PATCH v3 3/5] bootmeth: efi: use the firmware-owned devicetree Carlo Caione
2026-09-03 13:09 ` [PATCH v3 4/5] efi_loader: bootmgr: install " Carlo Caione
2026-09-08 8:37 ` Ilias Apalodimas
2026-09-08 9:09 ` Carlo Caione
2026-09-08 9:50 ` Ilias Apalodimas
2026-09-08 10:05 ` Carlo Caione [this message]
2026-09-03 13:09 ` [PATCH v3 5/5] test: boot: add firmware-FDT source tests Carlo Caione
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ap_dvWDuPmSNKD4g@macbook \
--to=ccaione@baylibre.com \
--cc=a.fatoum@barebox.org \
--cc=aristo.chen@canonical.com \
--cc=daniel@makrotopia.org \
--cc=dlechner@baylibre.com \
--cc=ilias.apalodimas@linaro.org \
--cc=james.hilliard1@gmail.com \
--cc=jbx6244@gmail.com \
--cc=jmasson@baylibre.com \
--cc=jonas@kwiboo.se \
--cc=marek.vasut+renesas@mailbox.org \
--cc=pbrobinson@gmail.com \
--cc=peng.fan@nxp.com \
--cc=quentin.schulz@cherry.de \
--cc=rs@ti.com \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.u-boot-project.org \
--cc=vjardin@free.fr \
--cc=vsatoes@baylibre.com \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.