From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B6A08C79F82 for ; Tue, 8 Sep 2026 11:08:49 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1688F10EB14; Tue, 8 Sep 2026 11:08:49 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=arm.com header.i=@arm.com header.b="JXwRZByQ"; dkim-atps=neutral Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by gabe.freedesktop.org (Postfix) with ESMTP id E92D310EB14 for ; Tue, 8 Sep 2026 11:08:46 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A44381476 for ; Tue, 8 Sep 2026 04:08:42 -0700 (PDT) Received: from [192.168.0.1] (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 1A1973F7B4 for ; Tue, 8 Sep 2026 04:08:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1788865726; bh=y4vz4D5RryrHFY2Ojox7ZbAALJZGSizZnfEyF/6Gj0M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JXwRZByQsmbInGmZXeCYbpJl6HWJvP+sshMc0Es+B9BgIW/AXqWX1yqQWOejIEB0M WJPwIJQdCxFF17Kg1wtV709YvJAZPLCjpHFbFq+m7JhJ2KVOFgakaeALGrA3oRi4BW 83EjC55jSnRSLwS1CcwgxIrWvmlmj2WiR9RsVsy4= Date: Tue, 8 Sep 2026 12:08:32 +0100 From: Liviu Dudau To: Nicolas Frattaroli Cc: Boris Brezillon , Steven Price , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel@collabora.com Subject: Re: [PATCH v3] drm/panthor: Display priorities of panthor groups over debugfs Message-ID: References: <20260904-panthor-sched-group-prio-v3-1-678afcca08b8@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260904-panthor-sched-group-prio-v3-1-678afcca08b8@collabora.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Sep 04, 2026 at 07:38:09PM +0200, Nicolas Frattaroli wrote: > Analogous to what was added in Commit d41c79838c47 ("drm/panfrost: > Display list of device JM contexts over debugfs") for panfrost, add > similar debugfs information for panthor. > > The group priority does not change over the lifetime of the group, so no > effort to synchronise with the scheduler lock is being made. > > Signed-off-by: Nicolas Frattaroli Reviewed-by: Liviu Dudau Best regards, Liviu > --- > Changes in v3: > - Move group number to after the per-file specific information, which > helps readability > - Link to v2: https://patch.msgid.link/20260831-panthor-sched-group-prio-v2-1-a74c79b4b830@collabora.com > > Changes in v2: > - Take groups xa lock around the loop in show_file_groups to guard > against group object UAF > - Flatten the listing, removing most of the code in show_each_file, > printing that info for each group instead > - Also show queue count for each group > - Link to v1: https://patch.msgid.link/20260818-panthor-sched-group-prio-v1-1-1836857c53e9@collabora.com > --- > drivers/gpu/drm/panthor/panthor_drv.c | 1 + > drivers/gpu/drm/panthor/panthor_sched.c | 73 +++++++++++++++++++++++++++++++++ > drivers/gpu/drm/panthor/panthor_sched.h | 5 +++ > 3 files changed, 79 insertions(+) > > diff --git a/drivers/gpu/drm/panthor/panthor_drv.c b/drivers/gpu/drm/panthor/panthor_drv.c > index 46a3080b0b20..8cdba0c1a14b 100644 > --- a/drivers/gpu/drm/panthor/panthor_drv.c > +++ b/drivers/gpu/drm/panthor/panthor_drv.c > @@ -1769,6 +1769,7 @@ static void panthor_debugfs_init(struct drm_minor *minor) > { > panthor_mmu_debugfs_init(minor); > panthor_gem_debugfs_init(minor); > + panthor_sched_debugfs_init(minor); > } > #endif > > diff --git a/drivers/gpu/drm/panthor/panthor_sched.c b/drivers/gpu/drm/panthor/panthor_sched.c > index 60b2417deb81..ac6aee554820 100644 > --- a/drivers/gpu/drm/panthor/panthor_sched.c > +++ b/drivers/gpu/drm/panthor/panthor_sched.c > @@ -1,6 +1,7 @@ > // SPDX-License-Identifier: GPL-2.0 or MIT > /* Copyright 2023 Collabora ltd. */ > > +#include > #include > #include > #include > @@ -4175,3 +4176,75 @@ int panthor_sched_init(struct panthor_device *ptdev) > ptdev->scheduler = sched; > return 0; > } > + > +#ifdef CONFIG_DEBUG_FS > + > +static const char * > +panthor_sched_prio_str(enum panthor_csg_priority prio) > +{ > + switch (prio) { > + case PANTHOR_CSG_PRIORITY_LOW: > + return "LOW"; > + case PANTHOR_CSG_PRIORITY_MEDIUM: > + return "MEDIUM"; > + case PANTHOR_CSG_PRIORITY_HIGH: > + return "HIGH"; > + case PANTHOR_CSG_PRIORITY_RT: > + return "REAL-TIME"; > + default: > + return "UNKNOWN"; > + } > +} > + > +static int show_file_groups(struct drm_file *file, struct seq_file *m) > +{ > + struct panthor_file *pfile = file->driver_priv; > + struct panthor_group *group; > + unsigned long i; > + > + if (IS_ERR_OR_NULL(pfile->groups)) > + return -ENOENT; > + > + xa_lock(&pfile->groups->xa); > + xa_for_each_marked(&pfile->groups->xa, i, group, GROUP_REGISTERED) { > + seq_printf(m, "client_id %8llu pid %8d command %s: group %2lu priority %s queue count %u\n", > + file->client_id, group->task_info.pid, group->task_info.comm, i, > + panthor_sched_prio_str(group->priority), group->queue_count); > + } > + xa_unlock(&pfile->groups->xa); > + > + return 0; > +} > + > +static int show_each_file(struct seq_file *m, void *arg) > +{ > + struct drm_info_node *node = (struct drm_info_node *)m->private; > + struct drm_device *ddev = node->minor->dev; > + int (*show)(struct drm_file *, struct seq_file *) = > + node->info_ent->data; > + struct drm_file *file; > + int ret; > + > + scoped_cond_guard(mutex_intr, return -EINTR, &ddev->filelist_mutex) { > + list_for_each_entry(file, &ddev->filelist, lhead) { > + ret = show(file, m); > + if (ret < 0) > + return ret; > + } > + } > + > + return 0; > +} > + > +static struct drm_info_list panthor_sched_debugfs_list[] = { > + { "sched_groups", show_each_file, 0, show_file_groups }, > +}; > + > +void panthor_sched_debugfs_init(struct drm_minor *minor) > +{ > + drm_debugfs_create_files(panthor_sched_debugfs_list, > + ARRAY_SIZE(panthor_sched_debugfs_list), > + minor->debugfs_root, minor); > +} > + > +#endif /* CONFIG_DEBUG_FS */ > diff --git a/drivers/gpu/drm/panthor/panthor_sched.h b/drivers/gpu/drm/panthor/panthor_sched.h > index 9a8692de8ade..d87cbdba4d40 100644 > --- a/drivers/gpu/drm/panthor/panthor_sched.h > +++ b/drivers/gpu/drm/panthor/panthor_sched.h > @@ -10,6 +10,7 @@ struct drm_file; > struct drm_gem_object; > struct drm_sched_job; > struct drm_memory_stats; > +struct drm_minor; > struct drm_panthor_group_create; > struct drm_panthor_queue_create; > struct drm_panthor_group_get_state; > @@ -55,4 +56,8 @@ void panthor_sched_report_fw_events(struct panthor_device *ptdev, u32 events); > > void panthor_fdinfo_gather_group_samples(struct panthor_file *pfile); > > +#ifdef CONFIG_DEBUG_FS > +void panthor_sched_debugfs_init(struct drm_minor *minor); > +#endif > + > #endif > > --- > base-commit: 17c6b88e85ffe5de5720004ae8c2176d52944aca > change-id: 20260814-panthor-sched-group-prio-c987f6a15690 > > Best regards, > -- > Nicolas Frattaroli > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯