From: Joe Damato <joe@dama.to>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
shuah@kernel.org, willemb@google.com, petrm@nvidia.com,
linux-kselftest@vger.kernel.org, noren@nvidia.com
Subject: Re: [PATCH net-next 2/3] selftests: drv-net: split gro.py into one test per coalescing mode
Date: Tue, 1 Sep 2026 08:34:16 -0700 [thread overview]
Message-ID: <apbweF6mzkEXLPbu@devvm20253.cco0.facebook.com> (raw)
In-Reply-To: <20260831163734.1121891-3-kuba@kernel.org>
On Mon, Aug 31, 2026 at 09:37:33AM -0700, Jakub Kicinski wrote:
> gro.py runs its full set of cases three times over - against SW GRO,
> HW GRO and LRO. It's our test with the longest runtime. The 318 cases
> take 12m30s on mlx5 with a debug kernel.
>
> Bumping the timeout for all tests feels wrong when we can so easily
> split the GRO test by execution mode. Shorter runtime also helps retry
> just the failing portion / mode (we retry failing tests to try to
> detect flakes vs real failures).
>
> Move the main logic to gro_lib.py and add one program per mode -
> gro_sw.py, gro_hw.py and gro_lro.py, 102 cases each. Move PPPoE to
> a dedicated test. It has been tacked onto the tests in an ugly way,
> and it only runs against SW GRO anyway.
>
> Note that unfortunately this will case a rename of all test cases.
> The mode moves from the case name to the test name
>
> gro.py test.sw_ipv4_data_same
>
> becomes
>
> gro_sw.py test.ipv4_data_same
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> We also saw 20min runs on gve, but those may have been errors.
> The GVE runner is very flaky and even when it runs it doesn't seem
> to execute the gro test. Perhaps because the test times out?
> ---
> tools/testing/selftests/drivers/net/Makefile | 9 ++-
> tools/testing/selftests/drivers/net/gro_hw.py | 14 ++++
> .../drivers/net/{gro.py => gro_lib.py} | 68 +++++++++----------
> .../testing/selftests/drivers/net/gro_lro.py | 15 ++++
> tools/testing/selftests/drivers/net/gro_sw.py | 14 ++++
> .../selftests/drivers/net/pppoe_gro.py | 46 +++++++++++++
> .../selftests/net/lib/ksft_setup_loopback.sh | 2 +-
> 7 files changed, 129 insertions(+), 39 deletions(-)
> create mode 100755 tools/testing/selftests/drivers/net/gro_hw.py
> rename tools/testing/selftests/drivers/net/{gro.py => gro_lib.py} (92%)
> mode change 100755 => 100644
> create mode 100755 tools/testing/selftests/drivers/net/gro_lro.py
> create mode 100755 tools/testing/selftests/drivers/net/gro_sw.py
> create mode 100755 tools/testing/selftests/drivers/net/pppoe_gro.py
>
Reviewed-by: Joe Damato <joe@dama.to>
next prev parent reply other threads:[~2026-09-01 15:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-31 16:37 [PATCH net-next 0/3] selftests: drv-net: split up gro.py Jakub Kicinski
2026-08-31 16:37 ` [PATCH net-next 1/3] selftests: drv-net: hw: rename gro_hw.py to gro_stats.py Jakub Kicinski
2026-08-31 19:52 ` Joe Damato
2026-08-31 16:37 ` [PATCH net-next 2/3] selftests: drv-net: split gro.py into one test per coalescing mode Jakub Kicinski
2026-09-01 15:34 ` Joe Damato [this message]
2026-09-01 19:44 ` Jakub Kicinski
2026-08-31 16:37 ` [PATCH net-next 3/3] selftests: drv-net: bump the timeout to 15min Jakub Kicinski
2026-09-01 15:35 ` Joe Damato
2026-09-01 6:45 ` [PATCH net-next 0/3] selftests: drv-net: split up gro.py Nimrod Oren
2026-09-01 14:07 ` Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=apbweF6mzkEXLPbu@devvm20253.cco0.facebook.com \
--to=joe@dama.to \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=noren@nvidia.com \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=shuah@kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.